<div dir="ltr">It helps to have the first line of the commit message be roughly descriptive, since it forms the brief commit summary in version tools and the subject line in commit email - just "NFC" is a bit unclear. Usually these sort of commits are described as, say "Suppress -Asserts unused-variable warning for variable only used in an assert".</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Jan 5, 2018 at 4:52 AM Evgeny Stupachenko via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: evstupac<br>
Date: Thu Jan  4 18:22:52 2018<br>
New Revision: 321854<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=321854&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=321854&view=rev</a><br>
Log:<br>
NFC.<br>
The patch fixes r321395, that cuased<br>
 -Werror=unused-but-set-variable issue for<br>
 Diagnosed var on prod build.<br>
<br>
From: Evgeny Stupachenko <<a href="mailto:evstupac@gmail.com" target="_blank">evstupac@gmail.com</a>><br>
<br>
Modified:<br>
    cfe/trunk/lib/Serialization/ASTReader.cpp<br>
<br>
Modified: cfe/trunk/lib/Serialization/ASTReader.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTReader.cpp?rev=321854&r1=321853&r2=321854&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTReader.cpp?rev=321854&r1=321853&r2=321854&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Serialization/ASTReader.cpp (original)<br>
+++ cfe/trunk/lib/Serialization/ASTReader.cpp Thu Jan  4 18:22:52 2018<br>
@@ -10660,6 +10660,7 @@ void ASTReader::diagnoseOdrViolations()<br>
       Diagnosed = true;<br>
       break;<br>
     }<br>
+    (void)Diagnosed;<br>
     assert(Diagnosed && "Unable to emit ODR diagnostic.");<br>
   }<br>
 }<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>