<div dir="ltr">Sure, this is post-commit review feedback.<br><br>vim with dvorak works in the sense that it's not unusable, but it's pretty awkward (see, for example, discussions like this: <a href="http://vim.wikia.com/wiki/Using_Vim_with_the_Dvorak_keyboard_layout">http://vim.wikia.com/wiki/Using_Vim_with_the_Dvorak_keyboard_layout</a> )</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jan 2, 2018 at 10:03 AM George Karpenkov <<a href="mailto:ekarpenkov@apple.com">ekarpenkov@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space">This patch has already landed — also IIRC e.g. vim on dvorak also uses hjkl navigation with no issues.</div><div style="word-wrap:break-word;line-break:after-white-space"><br><div><br><blockquote type="cite"><div>On Dec 25, 2017, at 11:21 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:</div><br class="m_-6641478398421116215Apple-interchange-newline"><div><div dir="ltr">any chance this can be implemented based on keyboard layout, so it's good for dvorak users as well? (maybe it already is, I don't know - just mentioning it in case)<br><br><div class="gmail_quote"><div dir="ltr">On Thu, Dec 21, 2017 at 2:58 PM George Karpenkov via Phabricator via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rC321320: [analyzer] Add Javascript to analyzer HTML output to allow keyboard navigation. (authored by george.karpenkov, committed by ).<br>
Herald added a subscriber: cfe-commits.<br>
<br>
Changed prior to commit:<br>
  <a href="https://reviews.llvm.org/D41414?vs=127919&id=127954#toc" rel="noreferrer" target="_blank">https://reviews.llvm.org/D41414?vs=127919&id=127954#toc</a><br>
<br>
Repository:<br>
  rC Clang<br>
<br>
<a href="https://reviews.llvm.org/D41414" rel="noreferrer" target="_blank">https://reviews.llvm.org/D41414</a><br>
<br>
Files:<br>
  lib/Rewrite/HTMLRewrite.cpp<br>
  lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div>
</div></blockquote></div><br></div></blockquote></div>