<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 21 December 2017 at 12:34, James Y Knight <span dir="ltr"><<a href="mailto:jyknight@google.com" target="_blank">jyknight@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="auto"><div>I totally agree with moving towards eliminating the <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">-m<os>-version-min flags, it's much better to put it in the target, and will clean up a lot of cruft in the driver, eventually.</span></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><br></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">Now -- we (or anyone else who runs into this) can simply start specifying the version in both locations ("-target x86_64-apple-ios10 -mios-simulator-version-min=10<wbr>"), so as to work with both new and old clang, and be closer to the ultimate goal of having only -target. That's an overall nicer workaround to suggest than switching to -darwin. But, yea, there's no need for *temporary* patch to fix things just for us.<br></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br></span></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">However, I do not understand why you're against committing the patch you mention as option #2 -- that seems like it'd be best for all users, by preserving compatibility with existing command-lines. </span>So, I'd still like that change to be committed, permanently, not temporarily. I'm sure we can't be the only ones running clang like "-target x86_64-apple-ios -mios-simulator-version-min=10<wbr>", and it seems unfortunate and unnecessary to break that, even if it can be worked around.</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><br></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">In the future, I'd hope the -m<os>-version-min arguments can be deprecated more and more -- warning whenever you use them to modify the platform or version at all, rather just on specification conflict; then, warn anytime you use them at all; then, remove them.</span> But in the meantime, it seems strictly better to preserve compatibility, don't you think?</div></div></span></div></div></div></blockquote><div><br></div><div>+ Duncan</div><div><br></div><div>Thanks, I think your argument is convincing. I think I will commit the change that you're proposing in the near future if there are no further objections.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="auto"><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><br></div></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><br></div></span></div><span class=""><div><br></div><div><div class="gmail_extra"><div class="gmail_quote">On Dec 21, 2017 2:11 PM, "Alex L" <<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>> wrote:<br type="attribution"><blockquote class="m_-8107057842567323150m_-6840658452912796952gmail-m_-7779273346431771448quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Thanks for raising your concerns.<div><br></div><div>We decided to avoid -m<os>-version-min flag in favor of -target to simplify the driver logic and to encourage the adoption of -target. Now after <span style="font-size:12.8px">r321145 we only warn about -m<os>-version-min flag when the OS version specified in it is different to the OS version specified in target, or when target has no OS version.</span></div><div><br></div><div><span style="font-size:12.8px">There are two possible solutions here:</span></div><div><span style="font-size:12.8px">1) You can still use -target with -</span><span style="font-size:12.8px">mios-simulator-version-min as before but you'd have to use '-target=x86_64-apple-darwin' to ensure that the iOS version specified by </span><span style="font-size:12.8px"> </span><span style="font-size:12.8px">'-mios-simulator-version-m<wbr>in' is used.</span></div><div><span style="font-size:12.8px">2) I also do have a patch that implements the logic that you propose (use the OS version in -m<os>-version-min flag if target has none). If you believe that the first solution is not suitable for your code then I can commit it. At the same time I believe that we would rather not use this patch, but if it's urgent for your projects then maybe I can land it now and then we can establish some sort of timeline for when it can be reverted?</span></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">Thanks,</span></div><div><span style="font-size:12.8px">Alex</span></div><div><span style="font-size:12.8px"><br></span></div></div><div class="m_-8107057842567323150m_-6840658452912796952gmail-m_-7779273346431771448elided-text"><div class="gmail_extra"><br><div class="gmail_quote">On 21 December 2017 at 08:00, James Y Knight <span dir="ltr"><<a href="mailto:jyknight@google.com" target="_blank">jyknight@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I think if a version number isn't explicitly specified in the -target value, the value from -m<platform>-version-min ought to still be used, as it was before.<div><br></div><div>Currently, clang will ignore the -m<platform>-version-min version number if the target has a particular OS specified, even if it has no version number as part of it.<br><div><br></div><div>(We should be able to workaround this change backwards-compatibly by specifying in both the -target argument and in the -m<platform>-version-min arguments, but I do think the behavior should be fixed.)</div></div></div></blockquote></div></div></div></blockquote></div></div></div></span></div>
</div>
</blockquote></div><br></div></div>