<div dir="ltr"><div><div>I fixed this with r320868.<br><br></div>Thanks<br><br></div>Galina<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 14, 2017 at 5:43 PM, Galina Kistanova <span dir="ltr"><<a href="mailto:gkistanova@gmail.com" target="_blank">gkistanova@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span style="font-family:monospace,monospace">Hello Zachary,<br><br>It looks like this commit added an error to one of our builders:<br><a href="http://lab.llvm.org:8011/builders/ubuntu-gcc7.1-werror/builds/3735" target="_blank">http://lab.llvm.org:8011/<wbr>builders/ubuntu-gcc7.1-werror/<wbr>builds/3735</a><br><br>. . .<br>FAILED: /usr/local/gcc-7.1/bin/g++-7.<wbr>1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/Object -I/home/buildslave/am1i-slv2/<wbr>ubuntu-gcc7.1-werror/llvm/lib/<wbr>Object -Iinclude -I/home/buildslave/am1i-slv2/<wbr>ubuntu-gcc7.1-werror/llvm/<wbr>include -Wno-noexcept-type -fPIC -fvisibility-inlines-hidden -Werror -Werror=date-time -std=c++11 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-<wbr>initializers -pedantic -Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor -Wno-comment -ffunction-sections -fdata-sections -O3 -fPIC -UNDEBUG -fno-exceptions -fno-rtti -MD -MT lib/Object/CMakeFiles/<wbr>LLVMObject.dir/COFFImportFile.<wbr>cpp.o -MF lib/Object/CMakeFiles/<wbr>LLVMObject.dir/COFFImportFile.<wbr>cpp.o.d -o lib/Object/CMakeFiles/<wbr>LLVMObject.dir/COFFImportFile.<wbr>cpp.o -c /home/buildslave/am1i-slv2/<wbr>ubuntu-gcc7.1-werror/llvm/lib/<wbr>Object/COFFImportFile.cpp<br>/home/buildslave/am1i-slv2/<wbr>ubuntu-gcc7.1-werror/llvm/lib/<wbr>Object/COFFImportFile.cpp: In member function ‘llvm::NewArchiveMember llvm::object::{anonymous}::<wbr>ObjectFactory::<wbr>createImportDescriptor(std::<wbr>vector<unsigned char, std::allocator<unsigned char> >&)’:<br>/home/buildslave/am1i-slv2/<wbr>ubuntu-gcc7.1-werror/llvm/lib/<wbr>Object/COFFImportFile.cpp:191:<wbr>28: error: enumeral and non-enumeral type in conditional expression [-Werror=extra]<br> u16(is32bit(Machine) ? IMAGE_FILE_32BIT_MACHINE : 0),<br> ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~<wbr>~~~~~~~~~~~~~~~~~<br>/home/buildslave/am1i-slv2/<wbr>ubuntu-gcc7.1-werror/llvm/lib/<wbr>Object/COFFImportFile.cpp: In member function ‘llvm::NewArchiveMember llvm::object::{anonymous}::<wbr>ObjectFactory::<wbr>createNullImportDescriptor(<wbr>std::vector<unsigned char, std::allocator<unsigned char> >&)’:<br>/home/buildslave/am1i-slv2/<wbr>ubuntu-gcc7.1-werror/llvm/lib/<wbr>Object/COFFImportFile.cpp:327:<wbr>28: error: enumeral and non-enumeral type in conditional expression [-Werror=extra]<br> u16(is32bit(Machine) ? IMAGE_FILE_32BIT_MACHINE : 0),<br> ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~<wbr>~~~~~~~~~~~~~~~~~<br>/home/buildslave/am1i-slv2/<wbr>ubuntu-gcc7.1-werror/llvm/lib/<wbr>Object/COFFImportFile.cpp: In member function ‘llvm::NewArchiveMember llvm::object::{anonymous}::<wbr>ObjectFactory::<wbr>createNullThunk(std::vector<<wbr>unsigned char, std::allocator<unsigned char> >&)’:<br>/home/buildslave/am1i-slv2/<wbr>ubuntu-gcc7.1-werror/llvm/lib/<wbr>Object/COFFImportFile.cpp:390:<wbr>28: error: enumeral and non-enumeral type in conditional expression [-Werror=extra]<br> u16(is32bit(Machine) ? IMAGE_FILE_32BIT_MACHINE : 0),<br> ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~<wbr>~~~~~~~~~~~~~~~~~<br>cc1plus: all warnings being treated as errors<br><br>The builder was already red and did not send notifications.<br>Please have a look?<br><br>Thanks<span class="HOEnZb"><font color="#888888"><br><br>Galina<br></font></span></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 14, 2017 at 2:07 PM, Zachary Turner via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: zturner<br>
Date: Thu Dec 14 14:07:03 2017<br>
New Revision: 320750<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=320750&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=320750&view=rev</a><br>
Log:<br>
Fix many -Wsign-compare and -Wtautological-constant-compar<wbr>e warnings.<br>
<br>
Most of the -Wsign-compare warnings are due to the fact that<br>
enums are signed by default in the MS ABI, while the<br>
tautological comparison warnings trigger on x86 builds where<br>
sizeof(size_t) is 4 bytes, so N > numeric_limits<unsigned>::max(<wbr>)<br>
is always false.<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D41256" rel="noreferrer" target="_blank">https://reviews.llvm.org/D4125<wbr>6</a><br>
<br>
Modified:<br>
cfe/trunk/lib/CodeGen/CGExpr.c<wbr>pp<br>
<br>
Modified: cfe/trunk/lib/CodeGen/CGExpr.c<wbr>pp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExpr.cpp?rev=320750&r1=320749&r2=320750&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/cfe/trunk/lib/CodeGen/CG<wbr>Expr.cpp?rev=320750&r1=320749&<wbr>r2=320750&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/lib/CodeGen/CGExpr.c<wbr>pp (original)<br>
+++ cfe/trunk/lib/CodeGen/CGExpr.c<wbr>pp Thu Dec 14 14:07:03 2017<br>
@@ -2825,7 +2825,7 @@ void CodeGenFunction::EmitCheck(<br>
assert(IsSanitizerScope);<br>
assert(Checked.size() > 0);<br>
assert(CheckHandler >= 0 &&<br>
- CheckHandler < sizeof(SanitizerHandlers) / sizeof(*SanitizerHandlers));<br>
+ size_t(CheckHandler) < llvm::array_lengthof(Sanitizer<wbr>Handlers));<br>
const StringRef CheckName = SanitizerHandlers[CheckHandler<wbr>].Name;<br>
<br>
llvm::Value *FatalCond = nullptr;<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>