<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">A Hangouts meeting sounds good! Yes, let's arrange via emails.<br>
</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Haojian Wu via Phabricator <reviews@reviews.llvm.org><br>
<b>Sent:</b> Friday, December 8, 2017 7:14:42 AM<br>
<b>To:</b> ioeric@google.com; Marc-André Laperle; sammccall@google.com<br>
<b>Cc:</b> hokein@google.com; klimek@google.com; mgorny@gentoo.org; ibiryukov@google.com; cfe-commits@lists.llvm.org<br>
<b>Subject:</b> [PATCH] D40548: [clangd] Symbol index interfaces and index-based code completion.</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">hokein added a comment.<br>
<br>
Thanks for the feedback, Marc!<br>
<br>
Yeah, I think the ClangdIndexDataSymbol and ClangdIndexDataOccurrence are something similar to what
<a href="https://reviews.llvm.org/D40897">https://reviews.llvm.org/D40897</a> trying to address, maybe put the discussion there? Before that, I think having a sym meeting is a good idea to keep us in the same page.<br>
<br>
In <a href="https://reviews.llvm.org/D40548#949279">https://reviews.llvm.org/D40548#949279</a>, @ioeric wrote:<br>
<br>
> > <br>
><br>
> I think some of the ideas here could be useful. This patch focuses mostly on index interfaces and
<a href="https://reviews.llvm.org/D40897">https://reviews.llvm.org/D40897</a> emphasizes on the design of symbol structure. The way symbols are stored and used in this patch is likely to change depending on how
<a href="https://reviews.llvm.org/D40897">https://reviews.llvm.org/D40897</a> goes.<br>
><br>
> > The "Clangd" prefix adds a bit much of clutter so maybe it should be removed. I think the main points are that having generic foreachSymbols/foreachOccurrence with callbacks is well suited to implement multiple features with minimal copying.<br>
><br>
> Although I'm not sure if `foreachSymbols`/... would be feasible for all indexes yet, we do plan to switch to callback-based index interfaces, which Sam also proposed in the review comments.<br>
><br>
> There have been some offline discussions happening around clangd's indexing, and sorry that we have not been able to keep you up to date. I think it might be more efficient if we could meet via VC/Hangouts and sync on our designs. If you don't mind a meeting,
I am happy to arrange it via emails.<br>
<br>
<br>
<br>
<br>
<br>
Repository:<br>
rCTE Clang Tools Extra<br>
<br>
<a href="https://reviews.llvm.org/D40548">https://reviews.llvm.org/D40548</a><br>
<br>
<br>
<br>
</div>
</span></font></div>
</body>
</html>