<div><div dir="auto">IIRC, and I can hardly guarantee I do, the issue is that libclang installing signal handlers doesn’t play well with the arbitrary applications which can be linking libclang.</div><div dir="auto"><br></div><div dir="auto"> - Daniel</div><br><div class="gmail_quote"><div>On Thu, Nov 16, 2017 at 3:26 PM Rafael Avila de Espindola <<a href="mailto:rafael.espindola@gmail.com">rafael.espindola@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Daniel Dunbar <<a href="mailto:daniel@zuster.org" target="_blank">daniel@zuster.org</a>> writes:<br>
<br>
> Author: ddunbar<br>
> Date: Mon Jan 31 16:00:44 2011<br>
> New Revision: 124613<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=124613&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=124613&view=rev</a><br>
> Log:<br>
> libclang: Don't allow RemoveFileOnSignal to be called via libclang, badness can<br>
> ensue.<br>
<br>
<br>
Sorry for digging out such an old commit, but do you remember what<br>
badness that ensues if RemoveFileOnSignal is called?<br>
<br>
Would the same badness ensue if FILE_FLAG_DELETE_ON_CLOSE were used on<br>
Windows?<br>
<br>
<br>
Thanks,<br>
Rafael<br>
<br>
<br>
> Modified:<br>
>     cfe/trunk/lib/Frontend/FrontendActions.cpp<br>
><br>
> Modified: cfe/trunk/lib/Frontend/FrontendActions.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/FrontendActions.cpp?rev=124613&r1=124612&r2=124613&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/FrontendActions.cpp?rev=124613&r1=124612&r2=124613&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/Frontend/FrontendActions.cpp (original)<br>
> +++ cfe/trunk/lib/Frontend/FrontendActions.cpp Mon Jan 31 16:00:44 2011<br>
> @@ -104,7 +104,10 @@<br>
>      return true;<br>
>    }<br>
><br>
> -  OS = CI.createDefaultOutputFile(true, InFile);<br>
> +  // We use createOutputFile here because this is exposed via libclang, and we<br>
> +  // must disable the RemoveFileOnSignal behavior.<br>
> +  OS = CI.createOutputFile(CI.getFrontendOpts().OutputFile, /*Binary=*/true,<br>
> +                           /*RemoveFileOnSignal=*/false, InFile);<br>
>    if (!OS)<br>
>      return true;<br>
><br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div>