<div dir="ltr">Hello Sam,<br><br>It looks like this commit broke the builder:<br><a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/13313">http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/13313</a><br><br>. . .<br>FAILED: tools/clang/tools/extra/unittests/clangd/CMakeFiles/ClangdTests.dir/JSONExprTests.cpp.obj<br><br>Please have a look?<br><br>Thanks<br><br>Galina<br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 7, 2017 at 12:57 AM, Sam McCall via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: sammccall<br>
Date: Tue Nov  7 00:57:54 2017<br>
New Revision: 317553<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=317553&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=317553&view=rev</a><br>
Log:<br>
[clangd] fix MSVC build errors<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/<wbr>clangd/JSONExpr.cpp<br>
    clang-tools-extra/trunk/<wbr>clangd/JSONExpr.h<br>
<br>
Modified: clang-tools-extra/trunk/<wbr>clangd/JSONExpr.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/JSONExpr.cpp?rev=317553&r1=317552&r2=317553&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/clang-tools-extra/<wbr>trunk/clangd/JSONExpr.cpp?rev=<wbr>317553&r1=317552&r2=317553&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- clang-tools-extra/trunk/<wbr>clangd/JSONExpr.cpp (original)<br>
+++ clang-tools-extra/trunk/<wbr>clangd/JSONExpr.cpp Tue Nov  7 00:57:54 2017<br>
@@ -2,10 +2,10 @@<br>
<br>
 #include "llvm/Support/Format.h"<br>
<br>
+using namespace llvm;<br>
 namespace clang {<br>
 namespace clangd {<br>
 namespace json {<br>
-using namespace llvm;<br>
<br>
 void Expr::copyFrom(const Expr &M) {<br>
   Type = M.Type;<br>
<br>
Modified: clang-tools-extra/trunk/<wbr>clangd/JSONExpr.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/JSONExpr.h?rev=317553&r1=317552&r2=317553&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/clang-tools-extra/<wbr>trunk/clangd/JSONExpr.h?rev=<wbr>317553&r1=317552&r2=317553&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- clang-tools-extra/trunk/<wbr>clangd/JSONExpr.h (original)<br>
+++ clang-tools-extra/trunk/<wbr>clangd/JSONExpr.h Tue Nov  7 00:57:54 2017<br>
@@ -154,7 +154,7 @@ public:<br>
     ObjectKey(const llvm::formatv_object_base &V) : ObjectKey(V.str()) {}<br>
<br>
     ObjectKey(const ObjectKey &C) { *this = C; }<br>
-    ObjectKey(ObjectKey &&C) = default;<br>
+    ObjectKey(ObjectKey &&C) : ObjectKey(static_cast<const ObjectKey &&>(C)) {}<br>
     ObjectKey &operator=(const ObjectKey &C) {<br>
       if (C.Owned) {<br>
         Owned.reset(new std::string(*C.Owned));<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>