<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">On Nov 1, 2017, at 17:22, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:<br class=""><div><blockquote type="cite" class=""><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Wed, Nov 1, 2017 at 5:13 PM Volodymyr Sapsai <<a href="mailto:vsapsai@apple.com" class="">vsapsai@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space" class="">On Nov 1, 2017, at 16:47, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank" class="">zturner@google.com</a>> wrote:<br class=""></div><div style="word-wrap:break-word;line-break:after-white-space" class=""><div class=""><blockquote type="cite" class=""><br class="m_-2225885694232795999Apple-interchange-newline"><div class="">This will remove the ability to use llvm-lit script even if source tree is available.<br class=""></div></blockquote></div></div><div style="word-wrap:break-word;line-break:after-white-space" class=""><div class=""><div class="">Can you please point me to the place where llvm-lit is enabled in configure_lit_site_cfg? Asking for my education, to understand lit configuration better and to avoid breaking it. And how do you test llvm-lit script if source tree is available? I tried to check out libcxx to llvm/projects/, `ninja check-libcxx` worked fine. Though I didn’t use extra options, so this case might not reflect real-world usage.</div></div></div></blockquote><div class=""><br class=""></div><div class="">configure_lit_site_cfg doesn't actually enable llvm-lit generation, but if llvm-lit generation is already enabled, then using configure_lit_site_cfg will cause additional information to be written to the generated llvm-lit script so that you can use bin/llvm-lit <path-to-source-tree>.</div><div class=""><br class=""></div><div class="">I think all you need to do is say:</div><div class=""><br class=""></div><div class="">if (LIBCXX_STANDALONE_BUILD)</div><div class=""> configure_file(...</div><div class="">else()</div><div class=""> configure_lit_site_cfg(...</div><div class="">endif()</div><div class=""><br class=""></div><div class="">If this doesn't work for some reason though, or is too much effort, I'm not opposed to your original patch, since I think llvm-lit script generation is unconditionally disabled for libcxx right now anyway.</div><div class=""> </div></div></div>
</div></blockquote></div><br class=""><div class="">Thanks, now I see that with my change in llvm-lit there is no mapping in config_map for libcxx/test/lit.cfg What is the purpose of this mapping? Is it only to make variables from <a href="http://lit.site" class="">lit.site</a>.cfg.in expanded during configuration available to lit.cfg? Or are there some other use cases?</div></body></html>