<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">On Nov 1, 2017, at 16:47, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:<br class=""><div><blockquote type="cite" class=""><br class="Apple-interchange-newline"><div class="">This will remove the ability to use llvm-lit script even if source tree is available.<br class=""></div></blockquote><div>Can you please point me to the place where llvm-lit is enabled in configure_lit_site_cfg? Asking for my education, to understand lit configuration better and to avoid breaking it. And how do you test llvm-lit script if source tree is available? I tried to check out libcxx to llvm/projects/, `ninja check-libcxx` worked fine. Though I didn’t use extra options, so this case might not reflect real-world usage.</div><br class=""><blockquote type="cite" class=""><div class="">Can you put this behind a check that for standalone build?<br class=""><br class="">Also, why was this just found? shouldnt this have been failing on Apple’s libcxx for the past several months?<br class=""></div></blockquote><div>It was found earlier, this specific fix is submitted for review only now.</div><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_quote"><div dir="ltr" class="">On Wed, Nov 1, 2017 at 4:38 PM Volodymyr Sapsai via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="">reviews@reviews.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">vsapsai created this revision.<br class="">
Herald added a subscriber: mgorny.<br class="">
<br class="">
Fixes error<br class="">
<br class="">
> CMake Error at test/CMakeLists.txt:52 (configure_lit_site_cfg):<br class="">
> Unknown CMake command "configure_lit_site_cfg".<br class="">
<br class="">
configure_lit_site_cfg is defined in AddLLVM module and not available<br class="">
without LLVM source tree. Revert back to configure_file (reverts part of<br class="">
r313643). It is possible as libcxx/test/<a href="http://lit.site.cfg.in/" rel="noreferrer" target="_blank" class="">lit.site.cfg.in</a> doesn't use<br class="">
latest lit capabilities.<br class="">
<br class="">
Tested with<br class="">
<br class="">
- in-tree libcxx - no change in generated lit.site.cfg and running tests;<br class="">
- standalone libcxx with lit checked out next to it - no CMake errors.<br class="">
<br class="">
If there are other tricky configurations worth testing, let me know.<br class="">
<br class="">
<a href="rdar://problem/35303262" class="">rdar://problem/35303262</a><br class="">
<br class="">
<br class="">
<a href="https://reviews.llvm.org/D39520" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D39520</a><br class="">
<br class="">
Files:<br class="">
libcxx/test/CMakeLists.txt<br class="">
<br class="">
<br class="">
Index: libcxx/test/CMakeLists.txt<br class="">
===================================================================<br class="">
--- libcxx/test/CMakeLists.txt<br class="">
+++ libcxx/test/CMakeLists.txt<br class="">
@@ -49,9 +49,10 @@<br class="">
<br class="">
set(AUTO_GEN_COMMENT "## Autogenerated by libcxx configuration.\n# Do not edit!")<br class="">
<br class="">
-configure_lit_site_cfg(<br class="">
+configure_file(<br class="">
${CMAKE_CURRENT_SOURCE_DIR}/<a href="http://lit.site.cfg.in/" rel="noreferrer" target="_blank" class="">lit.site.cfg.in</a><br class="">
- ${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg)<br class="">
+ ${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg<br class="">
+ @ONLY)<br class="">
<br class="">
set(LIBCXX_TEST_DEPS "")<br class="">
<br class="">
<br class="">
<br class="">
</blockquote></div>
</div></blockquote></div><br class=""></body></html>