<div><div dir="auto">Sure, I’ll add a release note.</div><div dir="auto"><br></div><div dir="auto">The type for the -fno-short-wchar shouldn’t have changed on ARM.  That sounds like a mistake.  We could just promote the -fsigned-wchar to a driver level flag.  Every target seems to use signed int, not unsigned int for wchar_t.</div><br><div class="gmail_quote"><div>On Wed, Oct 25, 2017 at 1:32 PM Friedman, Eli <<a href="mailto:efriedma@codeaurora.org">efriedma@codeaurora.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF">
    <div class="m_4134680888877748101moz-cite-prefix">On 10/25/2017 12:49 PM, Reid Kleckner
      wrote:<br>
    </div>
    <blockquote type="cite">
      <div>
        <div class="gmail_extra">
          <div class="gmail_quote">On Wed, Oct 25, 2017 at 12:14 PM,
            Friedman, Eli <span><<a href="mailto:efriedma@codeaurora.org" target="_blank">efriedma@codeaurora.org</a>></span>
            wrote:<br>
            <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <div text="#000000" bgcolor="#FFFFFF">
                <div>
                  <div class="m_4134680888877748101h5">
                    <div class="m_4134680888877748101m_4269100519850321198moz-cite-prefix"><span style="color:rgb(34,34,34)">Maybe we should just
                        ignore -fno-short-wchar, instead?  I think
                        that's what gcc and released versions of clang
                        do (that means -fno-short-wchar doesn't do
                        anything for Windows targets, but that's
                        probably fine).</span></div>
                  </div>
                </div>
              </div>
            </blockquote>
            <div><br>
            </div>
            <div>No, the intention of this change was to make
              -fno-short-wchar do something on Windows targets. </div>
          </div>
        </div>
      </div>
    </blockquote>
    </div><div text="#000000" bgcolor="#FFFFFF"><p>Really?  I don't see any mention of that in either the patch
      itself, or in the discussion of it.  It's fine, I guess, but
      please add a note to the release notes.</p></div><div text="#000000" bgcolor="#FFFFFF">
    <p>-Eli<br>
    </p>
    <pre class="m_4134680888877748101moz-signature" cols="72">-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project</pre>
  </div></blockquote></div></div><div dir="ltr">-- <br></div><div class="gmail_signature" data-smartmail="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>