<div dir="ltr">Generally it's preferably to avoid adding dead code (partly for this reason - it's hard to track when it gets used and ensure it's appropriately tested) could the member function's body be replaced with llvm_unreachable for now, then?</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Oct 16, 2017 at 10:27 AM Alex L <<a href="mailto:arphaman@gmail.com">arphaman@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">At the moment this method override is not used by the clang-refactor tool, so I don't think I can add a test for it.</div><div class="gmail_extra"><br><div class="gmail_quote">On 16 October 2017 at 10:11, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Is there a test that could be added to cover this new code?</div><div class="m_-1930247445518158196HOEnZb"><div class="m_-1930247445518158196h5"><br><div class="gmail_quote"><div dir="ltr">On Fri, Oct 13, 2017 at 2:15 PM Alex Lorenz via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: arphaman<br>
Date: Fri Oct 13 14:15:25 2017<br>
New Revision: 315755<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=315755&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=315755&view=rev</a><br>
Log:<br>
Fix -Woverloaded-virtual warning in clang-refactor<br>
<br>
Modified:<br>
    cfe/trunk/tools/clang-refactor/ClangRefactor.cpp<br>
<br>
Modified: cfe/trunk/tools/clang-refactor/ClangRefactor.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/clang-refactor/ClangRefactor.cpp?rev=315755&r1=315754&r2=315755&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/clang-refactor/ClangRefactor.cpp?rev=315755&r1=315754&r2=315755&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/tools/clang-refactor/ClangRefactor.cpp (original)<br>
+++ cfe/trunk/tools/clang-refactor/ClangRefactor.cpp Fri Oct 13 14:15:25 2017<br>
@@ -314,6 +314,10 @@ public:<br>
     SourceChanges.insert(SourceChanges.begin(), Changes.begin(), Changes.end());<br>
   }<br>
<br>
+  void handle(SymbolOccurrences Occurrences) override {<br>
+    RefactoringResultConsumer::handle(std::move(Occurrences));<br>
+  }<br>
+<br>
   const AtomicChanges &getSourceChanges() const { return SourceChanges; }<br>
<br>
 private:<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
</div></div></blockquote></div><br></div>
</blockquote></div>