<div dir="ltr">Is there missing test coverage for this?</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 10, 2017 at 9:12 AM Ilya Biryukov via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ibiryukov<br>
Date: Tue Oct 10 09:12:47 2017<br>
New Revision: 315323<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=315323&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=315323&view=rev</a><br>
Log:<br>
[clangd] Added forgotten return in UniqueFunction.<br>
<br>
This hasn't bitten us because we only used functions returning<br>
'void'.<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/clangd/Function.h<br>
<br>
Modified: clang-tools-extra/trunk/clangd/Function.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/Function.h?rev=315323&r1=315322&r2=315323&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/Function.h?rev=315323&r1=315322&r2=315323&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clangd/Function.h (original)<br>
+++ clang-tools-extra/trunk/clangd/Function.h Tue Oct 10 09:12:47 2017<br>
@@ -46,7 +46,7 @@ public:<br>
<br>
   Ret operator()(Args... As) {<br>
     assert(CallablePtr);<br>
-    CallablePtr->Call(std::forward<Args>(As)...);<br>
+    return CallablePtr->Call(std::forward<Args>(As)...);<br>
   }<br>
<br>
 private:<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>