<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">I haven't looked at the patch. If this is guarded behind NOT LIBCXX_STANDALONE_BUILD checks, then it's probably fine.<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Oct 4, 2017, at 21:36, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">This doesn’t match up with what beanz said. While I assume Duncan is the final word, can we get some confirmation from beanz that everyone is on the same page?<br class=""><br class="">(Note that libcxx already uses some of LLVM’s cmake, but it’s behind some NOT LIBCXX_STANDALONE_BUILD checks)<br class=""><br class="">Assuming the answer remains no, what can we do to make code sharing and reuse easier? There’s clearly a need to reuse certain low level things and not keep reinventing the wheel <br class=""><div class="gmail_quote"><div dir="ltr" class="">On Wed, Oct 4, 2017 at 9:22 PM Duncan P. N. Exon Smith <<a href="mailto:dexonsmith@apple.com" class="">dexonsmith@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks correct.<br class="">
<br class="">
> On Oct 4, 2017, at 18:49, Shoaib Meenai via Phabricator via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a>> wrote:<br class="">
><br class="">
> smeenai added subscribers: zturner, rjmccall.<br class="">
> smeenai added a comment.<br class="">
><br class="">
> @rjmccall, this adds a libc++ build dependency on LLVM's cmake modules. There were some issues when @zturner had added a similar dependency for his work on lit. To confirm, Apple still cares about the use case of building libc++ without having any LLVM cmake modules available (either from source or from an LLVM installation), right?<br class="">
><br class="">
><br class="">
> <a href="https://reviews.llvm.org/D31363" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D31363</a><br class="">
><br class="">
><br class="">
><br class="">
> _______________________________________________<br class="">
> cfe-commits mailing list<br class="">
> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a><br class="">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="">
<br class="">
</blockquote></div>
</div></blockquote></div><br class=""></body></html>