<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Great! Thanks Jonas<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Oct 3, 2017, at 10:54 AM, Jonas Toth <<a href="mailto:jonas.toth@gmail.com" class="">jonas.toth@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" class="">
<div text="#000000" bgcolor="#FFFFFF" class=""><p class="">Hi Juergen,</p><p class="">i did already work on fixing the issue I introduced with the
commits. I am currently waiting for the buildbot to catch up with
the committed fix.</p><p class="">As far as i can see, the newer commits did actually fix (at least
chapunis buildbot did go green again), but i have my eye on it.</p><p class="">Cheers, Jonas<br class="">
</p>
<br class="">
<div class="moz-cite-prefix">Am 03.10.2017 um 19:53 schrieb Juergen
Ributzka:<br class="">
</div>
<blockquote type="cite" cite="mid:CAKm37GaCA5zqhaZxG9ndn9OSsA=EXGZzKby4JmLN51zPPLbGyA@mail.gmail.com" class="">
<div dir="ltr" class="">Hi Jonas,
<div class=""><br class="">
</div>
<div class="">this new test is failing on Green Dragon:</div>
<div class=""><a href="http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA/39223/consoleFull#11207350448254eaf0-7326-4999-85b0-388101f2d404" moz-do-not-send="true" class="">http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA/39223/consoleFull#11207350448254eaf0-7326-4999-85b0-388101f2d404</a><br class="">
</div>
<div class=""><br class="">
</div>
<div class="">Could you please take a look?</div>
<div class=""><br class="">
</div>
<div class="">Thanks</div>
<div class=""><br class="">
</div>
<div class="">Cheers,</div>
<div class="">Juergen</div>
</div>
<div class="gmail_extra"><br class="">
<div class="gmail_quote">On Tue, Oct 3, 2017 at 9:25 AM, Jonas
Toth via cfe-commits <span dir="ltr" class=""><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" moz-do-not-send="true" class="">cfe-commits@lists.llvm.org</a>></span>
wrote:<br class="">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Author:
jonastoth<br class="">
Date: Tue Oct 3 09:25:01 2017<br class="">
New Revision: 314808<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=314808&view=rev" rel="noreferrer" target="_blank" moz-do-not-send="true" class="">http://llvm.org/viewvc/llvm-<wbr class="">project?rev=314808&view=rev</a><br class="">
Log:<br class="">
[clang-tidy] Fix bug 34747, streaming operators and
hicpp-signed-bitwise<br class="">
<br class="">
The bug happened with stream operations, that were not
recognized in all cases.<br class="">
Even there were already existing test for streaming classes,
they did not catch this bug.<br class="">
Adding the isolated example to the existing tests did not
trigger the bug.<br class="">
Therefore i created a new isolated file that did expose the
bug indeed.<br class="">
<br class="">
Differential: <a href="https://reviews.llvm.org/D38399" rel="noreferrer" target="_blank" moz-do-not-send="true" class="">https://reviews.llvm.org/<wbr class="">D38399</a><br class="">
reviewed by aaron.ballman<br class="">
<br class="">
Added:<br class="">
clang-tools-extra/trunk/test/<wbr class="">clang-tidy/hicpp-signed-<wbr class="">bitwise-bug34747.cpp<br class="">
Modified:<br class="">
clang-tools-extra/trunk/clang-<wbr class="">tidy/hicpp/SignedBitwiseCheck.<wbr class="">cpp<br class="">
<br class="">
Modified: clang-tools-extra/trunk/clang-<wbr class="">tidy/hicpp/SignedBitwiseCheck.<wbr class="">cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/hicpp/SignedBitwiseCheck.cpp?rev=314808&r1=314807&r2=314808&view=diff" rel="noreferrer" target="_blank" moz-do-not-send="true" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/clang-tools-extra/<wbr class="">trunk/clang-tidy/hicpp/<wbr class="">SignedBitwiseCheck.cpp?rev=<wbr class="">314808&r1=314807&r2=314808&<wbr class="">view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- clang-tools-extra/trunk/clang-<wbr class="">tidy/hicpp/SignedBitwiseCheck.<wbr class="">cpp
(original)<br class="">
+++ clang-tools-extra/trunk/clang-<wbr class="">tidy/hicpp/SignedBitwiseCheck.<wbr class="">cpp
Tue Oct 3 09:25:01 2017<br class="">
@@ -27,7 +27,9 @@ void SignedBitwiseCheck::<wbr class="">registerMatcher<br class="">
binaryOperator(allOf(anyOf(<wbr class="">hasOperatorName("|"),
hasOperatorName("&"),<br class="">
hasOperatorName("^"),
hasOperatorName("<<"),<br class="">
hasOperatorName(">>")),<br class="">
- hasEitherOperand(<wbr class="">SignedIntegerOperand)))<br class="">
+ hasEitherOperand(<wbr class="">SignedIntegerOperand),<br class="">
+ hasLHS(hasType(isInteger())),<br class="">
+ hasRHS(hasType(isInteger()))))<br class="">
.bind("binary_signed"),<br class="">
this);<br class="">
<br class="">
<br class="">
Added: clang-tools-extra/trunk/test/<wbr class="">clang-tidy/hicpp-signed-<wbr class="">bitwise-bug34747.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/hicpp-signed-bitwise-bug34747.cpp?rev=314808&view=auto" rel="noreferrer" target="_blank" moz-do-not-send="true" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/clang-tools-extra/<wbr class="">trunk/test/clang-tidy/hicpp-<wbr class="">signed-bitwise-bug34747.cpp?<wbr class="">rev=314808&view=auto</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- clang-tools-extra/trunk/test/<wbr class="">clang-tidy/hicpp-signed-<wbr class="">bitwise-bug34747.cpp
(added)<br class="">
+++ clang-tools-extra/trunk/test/<wbr class="">clang-tidy/hicpp-signed-<wbr class="">bitwise-bug34747.cpp
Tue Oct 3 09:25:01 2017<br class="">
@@ -0,0 +1,21 @@<br class="">
+// RUN: %check_clang_tidy %s hicpp-signed-bitwise %t -- --
-std=c++11 | count 0<br class="">
+<br class="">
+// Note: this test expects no diagnostics, but FileCheck
cannot handle that,<br class="">
+// hence the use of | count 0.<br class="">
+<br class="">
+template <typename C><br class="">
+struct OutputStream {<br class="">
+ OutputStream &operator<<(C);<br class="">
+};<br class="">
+<br class="">
+template <typename C><br class="">
+struct foo {<br class="">
+ typedef OutputStream<C> stream_type;<br class="">
+ foo(stream_type &o) {<br class="">
+ o << 'x'; // warning occured here, fixed now<br class="">
+ }<br class="">
+};<br class="">
+<br class="">
+void bar(OutputStream<signed char> &o) {<br class="">
+ foo<signed char> f(o);<br class="">
+}<br class="">
<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" moz-do-not-send="true" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" moz-do-not-send="true" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/cfe-commits</a><br class="">
</blockquote>
</div>
<br class="">
</div>
</blockquote>
<br class="">
</div>
</div></blockquote></div><br class=""></body></html>