<div dir="ltr">This still doesn't work on some compilers, because std::is_trivially_copyable isn't available:<div><a href="http://lab.llvm.org:8011/builders/aosp-O3-polly-before-vectorizer-unprofitable/builds/265/steps/build/logs/stdio">http://lab.llvm.org:8011/builders/aosp-O3-polly-before-vectorizer-unprofitable/builds/265/steps/build/logs/stdio</a><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 27, 2017 at 10:00 PM, Faisal Vali via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: faisalv<br>
Date: Wed Sep 27 19:00:40 2017<br>
New Revision: 314373<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=314373&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=314373&view=rev</a><br>
Log:<br>
[NFC] Don't use C++17 standard lib variable template helper traits, instead use ::value.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Lex/MacroArgs.<wbr>cpp<br>
<br>
Modified: cfe/trunk/lib/Lex/MacroArgs.<wbr>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Lex/MacroArgs.cpp?rev=314373&r1=314372&r2=314373&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/lib/Lex/<wbr>MacroArgs.cpp?rev=314373&r1=<wbr>314372&r2=314373&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/lib/Lex/MacroArgs.<wbr>cpp (original)<br>
+++ cfe/trunk/lib/Lex/MacroArgs.<wbr>cpp Wed Sep 27 19:00:40 2017<br>
@@ -62,7 +62,7 @@ MacroArgs *MacroArgs::create(const Macro<br>
<br>
   // Copy the actual unexpanded tokens to immediately after the result ptr.<br>
   if (!UnexpArgTokens.empty()) {<br>
-    static_assert(std::is_<wbr>trivially_copyable_v<Token>,<br>
+    static_assert(std::is_<wbr>trivially_copyable<Token>::<wbr>value,<br>
                   "assume trivial copyability if copying into the "<br>
                   "uninitialized array (as opposed to reusing a cached "<br>
                   "MacroArgs)");<br>
@@ -96,7 +96,7 @@ MacroArgs *MacroArgs::deallocate() {<br>
   // Run the dtor to deallocate the vectors.<br>
   this->~MacroArgs();<br>
   // Release the memory for the object.<br>
-  static_assert(std::is_<wbr>trivially_destructible_v<<wbr>Token>,<br>
+  static_assert(std::is_<wbr>trivially_destructible<Token>:<wbr>:value,<br>
                 "assume trivially destructible and forego destructors");<br>
   free(this);<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>