<div dir="ltr">Is there also missing test coverage here?</div><br><div class="gmail_quote"><div dir="ltr">On Sun, Sep 24, 2017 at 8:19 AM Simon Pilgrim via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rksimon<br>
Date: Sun Sep 24 08:17:46 2017<br>
New Revision: 314079<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=314079&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=314079&view=rev</a><br>
Log:<br>
Fix implicit-fallthrough warning by adding missing break<br>
<br>
Modified:<br>
    cfe/trunk/lib/CrossTU/CrossTranslationUnit.cpp<br>
<br>
Modified: cfe/trunk/lib/CrossTU/CrossTranslationUnit.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CrossTU/CrossTranslationUnit.cpp?rev=314079&r1=314078&r2=314079&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CrossTU/CrossTranslationUnit.cpp?rev=314079&r1=314078&r2=314079&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/CrossTU/CrossTranslationUnit.cpp (original)<br>
+++ cfe/trunk/lib/CrossTU/CrossTranslationUnit.cpp Sun Sep 24 08:17:46 2017<br>
@@ -185,6 +185,7 @@ void CrossTranslationUnitContext::emitCr<br>
   case index_error_code::invalid_index_format:<br>
     Context.getDiagnostics().Report(diag::err_fnmap_parsing)<br>
         << IE.getFileName() << IE.getLineNum();<br>
+    break;<br>
   case index_error_code::multiple_definitions:<br>
     Context.getDiagnostics().Report(diag::err_multiple_def_index)<br>
         << IE.getLineNum();<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>