<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 30 August 2017 at 11:52, Boris Kolpackov via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Victor Leschuk <<a href="mailto:vleschuk@accesssoftek.com">vleschuk@accesssoftek.com</a>> writes:<br>
<br>
> Hello Boris, looks like this revision broke tests on our win10 builder:<br>
> <a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/11760" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/llvm-clang-lld-x86_<wbr>64-scei-ps4-windows10pro-fast/<wbr>builds/11760</a><br>
><br>
> Clang :: CXX/modules-ts/basic/basic.<wbr>link/module-declaration.cpp<br>
><br>
> I had to revert this revision. Could you please take a look?<br>
<br>
</span>Sorry about that.<br>
<br>
I took a look and it seems the problem is with the test's path regex:<br>
<br>
'{{.*}}/x.pcm'<br>
<br>
Which, on Windows, is being matched against a path like this:<br>
<br>
...\module-declaration.cpp.<wbr>tmp\x.pcm<br>
<br>
It looks like the "canonical" fix for this is to use [/\\].<br>
<br>
What is the protocol in this situation? Should I fix the test and then<br>
re-apply my patch?</blockquote><div><br></div><div>Yes, please. </div></div></div></div>