<div dir="ltr"><div>This commit causes <a href="http://llvm.org/PR34309">http://llvm.org/PR34309</a>. Could you take a look?</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 14, 2017 at 11:23 PM, Alexander Shaposhnikov via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: alexshap<br>
Date: Mon Aug 14 14:23:08 2017<br>
New Revision: 310887<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=310887&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=310887&view=rev</a><br>
Log:<br>
[analyzer] Fix SimpleSValBuilder::<wbr>simplifySVal<br>
<br>
This diff fixes a crash (triggered assert) on the newly added test case.<br>
In the method Simplifier::VisitSymbolData we check the type of S and return<br>
Loc/NonLoc accordingly.<br>
<br>
Differential revision: <a href="https://reviews.llvm.org/D36564" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D36564</a><br>
<br>
Modified:<br>
    cfe/trunk/lib/StaticAnalyzer/<wbr>Core/SimpleSValBuilder.cpp<br>
    cfe/trunk/test/Analysis/ptr-<wbr>arith.cpp<br>
<br>
Modified: cfe/trunk/lib/StaticAnalyzer/<wbr>Core/SimpleSValBuilder.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp?rev=310887&r1=310886&r2=310887&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/lib/<wbr>StaticAnalyzer/Core/<wbr>SimpleSValBuilder.cpp?rev=<wbr>310887&r1=310886&r2=310887&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/lib/StaticAnalyzer/<wbr>Core/SimpleSValBuilder.cpp (original)<br>
+++ cfe/trunk/lib/StaticAnalyzer/<wbr>Core/SimpleSValBuilder.cpp Mon Aug 14 14:23:08 2017<br>
@@ -1016,7 +1016,8 @@ SVal SimpleSValBuilder::<wbr>simplifySVal(Pro<br>
               SVB.getKnownValue(State, nonloc::SymbolVal(S)))<br>
         return Loc::isLocType(S->getType()) ? (SVal)SVB.makeIntLocVal(*I)<br>
                                             : (SVal)SVB.makeIntVal(*I);<br>
-      return nonloc::SymbolVal(S);<br>
+      return Loc::isLocType(S->getType()) ? (SVal)SVB.makeLoc(S)<br>
+                                          : nonloc::SymbolVal(S);<br>
     }<br>
<br>
     // TODO: Support SymbolCast. Support IntSymExpr when/if we actually<br>
<br>
Modified: cfe/trunk/test/Analysis/ptr-<wbr>arith.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/ptr-arith.cpp?rev=310887&r1=310886&r2=310887&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/test/<wbr>Analysis/ptr-arith.cpp?rev=<wbr>310887&r1=310886&r2=310887&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/test/Analysis/ptr-<wbr>arith.cpp (original)<br>
+++ cfe/trunk/test/Analysis/ptr-<wbr>arith.cpp Mon Aug 14 14:23:08 2017<br>
@@ -98,3 +98,10 @@ void checkMultiDimansionalArray() {<br>
   int a[5][5];<br>
    *(*(a+1)+2) = 2;<br>
 }<br>
+<br>
+unsigned ptrSubtractionNoCrash(char *Begin, char *End) {<br>
+  auto N = End - Begin;<br>
+  if (Begin)<br>
+    return 0;<br>
+  return N;<br>
+}<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>