<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Aug 22, 2017 at 5:56 PM, Reid Kleckner via Phabricator via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">rnk added a comment.<br>
<br>
Looks functionally correct<br>
<br>
<br>
<br>
================<br>
Comment at: test/Sema/warn-unreachable-ms.<wbr>c:42<br>
+  }<br>
+}<br>
----------------<br>
Can we add a test to exercise that this builds the right CFG?<br>
```<br>
__try {<br>
  __try {<br>
    f();<br>
  } __except(1) {<br>
    __leave; // should exit outer try<br>
  }<br>
  __leave;<br>
  f(); // expected-warning{{never be executed}}<br>
} __except(1) {<br>
}<br>
```<br></blockquote><div><br></div><div>Sure. Did you intentionally put two __leaves in there, or do you only want the one in the inner __except?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
<br>
<a href="https://reviews.llvm.org/D36914" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D36914</a><br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div></div>