<div dir="auto">probably shouldn't merge this then.</div><div class="gmail_extra"><br><div class="gmail_quote">On Aug 17, 2017 4:54 PM, "Petr Hosek via cfe-commits" <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">This broke our build of WebKit with the following build failure:<div><br></div><div><div>../../buildtools/linux-x64/<wbr>clang/bin/clang++ -MD -MF obj/apps/web_view/web_view_<wbr>test.test_webview.o.d -DTOOLCHAIN_VERSION=<wbr>4e89c701396412a50a901115ab4a2a<wbr>09145f3777 -D_LIBCPP_ENABLE_THREAD_<wbr>SAFETY_ANNOTATIONS -DCAIRO_HAS_FC_FONT=0 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_<wbr>DATA_FILE -I../.. -Igen -I../../third_party/webkit/<wbr>Source/WebKit/fuchsia -I../../third_party/boringssl/<wbr>include -Igen/third_party/cairo -I../../third_party/curl/<wbr>include -Iobj/third_party/curl -Iobj/third_party/curl/curl -I../../third_party/freetype2/<wbr>include -I../../third_party/harfbuzz/<wbr>src -I../../third_party/icu/<wbr>source/common -I../../third_party/icu/<wbr>source/i18n -I../../third_party/libjpeg-<wbr>turbo -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/libxml2/<wbr>include -I../../third_party/sqlite -g --sysroot=/usr/local/google/<wbr>home/phosek/fuchsia/out/build-<wbr>magenta/build-magenta-pc-x86-<wbr>64/sysroot --target=x86_64-fuchsia -no-canonical-prefixes -fdebug-prefix-map=/usr/local/<wbr>google/home/phosek/fuchsia=. -Wall -Wextra -Wno-unused-parameter -Wno-enum-compare-switch -Wno-unused-lambda-capture -Wno-user-defined-warnings -fvisibility=hidden -g -Og -fsanitize=safe-stack -fstack-protector-strong -Werror -Wno-error=deprecated-<wbr>declarations -fvisibility-inlines-hidden -std=c++14 -fno-exceptions -fno-rtti -Wthread-safety -c ../../apps/web_view/test_<wbr>webview.cpp -o obj/apps/web_view/web_view_<wbr>test.test_webview.o</div><div>In file included from ../../apps/web_view/test_<wbr>webview.cpp:1:</div><div>In file included from ../../third_party/webkit/<wbr>Source/WebKit/fuchsia/WebView.<wbr>h:28:</div><div>In file included from ../../buildtools/linux-x64/<wbr>clang/lib/x86_64-fuchsia/<wbr>include/c++/v1/functional:484:</div><div>../../buildtools/linux-x64/<wbr>clang/lib/x86_64-fuchsia/<wbr>include/c++/v1/type_traits:<wbr>4323:23: error: implicit instantiation of undefined template 'std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char> >'</div><div>_LIBCPP_INVOKE_RETURN(_VSTD::<wbr>forward<_Fp>(__f)(_VSTD::<wbr>forward<_Args>(__args)...))</div><div> ^</div><div>../../buildtools/linux-x64/<wbr>clang/lib/x86_64-fuchsia/<wbr>include/c++/v1/__config:468:<wbr>15: note: expanded from macro '_VSTD'</div><div>#define _VSTD std::_LIBCPP_NAMESPACE</div><div> ^</div><div>../../buildtools/linux-x64/<wbr>clang/lib/x86_64-fuchsia/<wbr>include/c++/v1/type_traits:<wbr>4340:9: note: in instantiation of exception specification for '__invoke<std::__2::function<<wbr>std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char> > (const std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char> > &)> &, const std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char> > &>' requested here</div><div> _VSTD::__invoke(_VSTD::<wbr>declval<_Fp>(), _VSTD::declval<_Args>()...));</div><div> ^</div><div>../../buildtools/linux-x64/<wbr>clang/lib/x86_64-fuchsia/<wbr>include/c++/v1/__config:468:<wbr>15: note: expanded from macro '_VSTD'</div><div>#define _VSTD std::_LIBCPP_NAMESPACE</div><div> ^</div><div>../../buildtools/linux-x64/<wbr>clang/lib/x86_64-fuchsia/<wbr>include/c++/v1/functional:<wbr>1601:33: note: in instantiation of template class 'std::__2::__invokable_r<void, std::__2::function<std::__2::<wbr>basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char> > (const std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char> > &)> &, const std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char> > &>' requested here</div><div> __invokable<_Fp&, _ArgTypes...>::value></div><div> ^</div><div>../../buildtools/linux-x64/<wbr>clang/lib/x86_64-fuchsia/<wbr>include/c++/v1/functional:<wbr>1626:9: note: in instantiation of default argument for '__callable<std::__2::<wbr>function<std::__2::basic_<wbr>string<char, std::__2::char_traits<char>, std::__2::allocator<char> > (const std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char> > &)> >' required here</div><div> __callable<_Fp>::value && !is_same<_Fp, function>::value</div><div> ^~~~~~~~~~~~~~~</div><div>../../buildtools/linux-x64/<wbr>clang/lib/x86_64-fuchsia/<wbr>include/c++/v1/functional:<wbr>1628:5: note: in instantiation of default argument for 'function<std::__2::function<<wbr>std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char> > (const std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char> > &)> >' required here</div><div> function(_Fp);</div><div> ^~~~~~~~~~~~~</div><div>../../buildtools/linux-x64/<wbr>clang/lib/x86_64-fuchsia/<wbr>include/c++/v1/functional:<wbr>1588:28: note: while substituting deduced template arguments into function template 'function' [with _Fp = std::__2::function<std::__2::<wbr>basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char> > (const std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char> > &)>, $1 = (no value)]</div><div>class _LIBCPP_TEMPLATE_VIS function<_Rp(_ArgTypes...)></div><div> ^</div><div>../../third_party/webkit/<wbr>Source/WebKit/fuchsia/WebView.<wbr>h:48:7: note: while declaring the implicit copy constructor for 'WebView'</div><div>class WebView {</div><div> ^</div><div>../../buildtools/linux-x64/<wbr>clang/lib/x86_64-fuchsia/<wbr>include/c++/v1/iosfwd:193:32: note: template is declared here</div><div> class _LIBCPP_TEMPLATE_VIS basic_string;</div><div> ^</div><div>1 error generated.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Aug 9, 2017 at 4:50 PM Hans Wennborg via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Marshall: ping?<br>
<br>
On Thu, Aug 3, 2017 at 10:20 AM, Hans Wennborg <<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>> wrote:<br>
> Sounds good to me, but Eric or Marshall need to sign off.<br>
><br>
> On Thu, Aug 3, 2017 at 10:15 AM, Shoaib Meenai <<a href="mailto:smeenai@fb.com" target="_blank">smeenai@fb.com</a>> wrote:<br>
>> Ping.<br>
>><br>
>> On 7/28/17, 7:57 PM, "Shoaib Meenai" <<a href="mailto:smeenai@fb.com" target="_blank">smeenai@fb.com</a>> wrote:<br>
>><br>
>> Marshall, Eric, Hans,<br>
>><br>
>> Any objections to backporting this to 5.0? It fixes a potential visibility<br>
>> issue for clients of the header.<br>
>><br>
>> On 7/28/17, 7:54 PM, "cfe-commits on behalf of Shoaib Meenai via cfe-commits" <<a href="mailto:cfe-commits-bounces@lists.llvm.org" target="_blank">cfe-commits-bounces@lists.<wbr>llvm.org</a> on behalf of <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
>><br>
>> Author: smeenai<br>
>> Date: Fri Jul 28 19:54:41 2017<br>
>> New Revision: 309474<br>
>><br>
>> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D309474-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=EcGbIxegCOTbSLMJelp_vOaeGiS_iQ1eciM_oeX41-E&s=5q7TS5mhaUsf-1jQBqX62RvjcqAiy2whh8RO7yFhPyA&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.<wbr>com/v2/url?u=http-3A__llvm.<wbr>org_viewvc_llvm-2Dproject-<wbr>3Frev-3D309474-26view-3Drev&d=<wbr>DwIGaQ&c=<wbr>5VD0RTtNlTh3ycd41b3MUw&r=<wbr>o3kDXzdBUE3ljQXKeTWOMw&m=<wbr>EcGbIxegCOTbSLMJelp_vOaeGiS_<wbr>iQ1eciM_oeX41-E&s=<wbr>5q7TS5mhaUsf-<wbr>1jQBqX62RvjcqAiy2whh8RO7yFhPyA<wbr>&e=</a><br>
>> Log:<br>
>> [libc++] Hoist extern template above first use<br>
>><br>
>> This function template is referenced inside class basic_string as a<br>
>> friend function. The extern template declaration needs to be above that<br>
>> friend declaration to actually take effect.<br>
>><br>
>> This is important because this function was marked as exported in<br>
>> r307966, so without the extern template taking effect, it can leak into<br>
>> other DSOs as a visible symbol.<br>
>><br>
>> Modified:<br>
>> libcxx/trunk/include/string<br>
>><br>
>> Modified: libcxx/trunk/include/string<br>
>> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_libcxx_trunk_include_string-3Frev-3D309474-26r1-3D309473-26r2-3D309474-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=EcGbIxegCOTbSLMJelp_vOaeGiS_iQ1eciM_oeX41-E&s=zFJXc9CA6Sgyh25kGeAh4Qo36gpNQX_zo2qRlRFJoL8&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.<wbr>com/v2/url?u=http-3A__llvm.<wbr>org_viewvc_llvm-2Dproject_<wbr>libcxx_trunk_include_string-<wbr>3Frev-3D309474-26r1-3D309473-<wbr>26r2-3D309474-26view-3Ddiff&d=<wbr>DwIGaQ&c=<wbr>5VD0RTtNlTh3ycd41b3MUw&r=<wbr>o3kDXzdBUE3ljQXKeTWOMw&m=<wbr>EcGbIxegCOTbSLMJelp_vOaeGiS_<wbr>iQ1eciM_oeX41-E&s=<wbr>zFJXc9CA6Sgyh25kGeAh4Qo36gpNQX<wbr>_zo2qRlRFJoL8&e=</a><br>
>> =============================<wbr>==============================<wbr>===================<br>
>> --- libcxx/trunk/include/string (original)<br>
>> +++ libcxx/trunk/include/string Fri Jul 28 19:54:41 2017<br>
>> @@ -556,6 +556,8 @@ template<class _CharT, class _Traits, cl<br>
>> basic_string<_CharT, _Traits, _Allocator><br>
>> operator+(const basic_string<_CharT, _Traits, _Allocator>& __x, _CharT __y);<br>
>><br>
>> +_LIBCPP_EXTERN_TEMPLATE(_<wbr>LIBCPP_FUNC_VIS string operator+<char, char_traits<char>, allocator<char> >(char const*, string const&))<br>
>> +<br>
>> template <bool><br>
>> class _LIBCPP_TEMPLATE_VIS __basic_string_common<br>
>> {<br>
>> @@ -3999,7 +4001,6 @@ basic_string<_CharT, _Traits, _Allocator<br>
>><br>
>> _LIBCPP_EXTERN_TEMPLATE(class _LIBCPP_EXTERN_TEMPLATE_TYPE_<wbr>VIS basic_string<char>)<br>
>> _LIBCPP_EXTERN_TEMPLATE(class _LIBCPP_EXTERN_TEMPLATE_TYPE_<wbr>VIS basic_string<wchar_t>)<br>
>> -_LIBCPP_EXTERN_TEMPLATE(_<wbr>LIBCPP_FUNC_VIS string operator+<char, char_traits<char>, allocator<char> >(char const*, string const&))<br>
>><br>
>> #if _LIBCPP_STD_VER > 11<br>
>> // Literal suffixes for basic_string [basic.string.literals]<br>
>><br>
>><br>
>> _____________________________<wbr>__________________<br>
>> cfe-commits mailing list<br>
>> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
>> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=EcGbIxegCOTbSLMJelp_vOaeGiS_iQ1eciM_oeX41-E&s=95GYNfQT_kBVjYvYRYnF3mje6PEyF4EDl4MCBQKCu88&e=" rel="noreferrer" target="_blank">https://urldefense.<wbr>proofpoint.com/v2/url?u=http-<wbr>3A__lists.llvm.org_cgi-2Dbin_<wbr>mailman_listinfo_cfe-<wbr>2Dcommits&d=DwIGaQ&c=<wbr>5VD0RTtNlTh3ycd41b3MUw&r=<wbr>o3kDXzdBUE3ljQXKeTWOMw&m=<wbr>EcGbIxegCOTbSLMJelp_vOaeGiS_<wbr>iQ1eciM_oeX41-E&s=95GYNfQT_<wbr>kBVjYvYRYnF3mje6PEyF4EDl4MCBQK<wbr>Cu88&e=</a><br>
>><br>
>><br>
>><br>
>><br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div></div>
<br>______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div></div>