<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Probably not, this might be a risky change.<br>
- Erik<br>
<br>
<div class="moz-cite-prefix">On 8/15/17 9:15 AM, Nico Weber wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAMGbLiFpNa6TDL14CJ5ina8HnWf0sU3ndLA9bz9r-MNz348XhQ@mail.gmail.com">
<div dir="ltr">Do we want to merge this to 5.0?</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Aug 8, 2017 at 1:09 PM, Erik
Pilkington via cfe-commits <span dir="ltr"><<a
href="mailto:cfe-commits@lists.llvm.org" target="_blank"
moz-do-not-send="true">cfe-commits@lists.llvm.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Author:
epilk<br>
Date: Tue Aug 8 10:09:09 2017<br>
New Revision: 310382<br>
<br>
URL: <a
href="http://llvm.org/viewvc/llvm-project?rev=310382&view=rev"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://llvm.org/viewvc/llvm-<wbr>project?rev=310382&view=rev</a><br>
Log:<br>
[Availability] Don't make an availability attribute imply
default visibility on macOS<br>
<br>
Fixes PR33796, <a class="moz-txt-link-freetext" href="rdar://33655115">rdar://33655115</a><br>
<br>
Differential revision: <a
href="https://reviews.llvm.org/D36191" rel="noreferrer"
target="_blank" moz-do-not-send="true">https://reviews.llvm.org/<wbr>D36191</a><br>
<br>
Modified:<br>
cfe/trunk/docs/ReleaseNotes.<wbr>rst<br>
cfe/trunk/lib/AST/Decl.cpp<br>
cfe/trunk/test/CodeGen/attr-<wbr>availability.c<br>
<br>
Modified: cfe/trunk/docs/ReleaseNotes.<wbr>rst<br>
URL: <a
href="http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/ReleaseNotes.rst?rev=310382&r1=310381&r2=310382&view=diff"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/docs/<wbr>ReleaseNotes.rst?rev=310382&<wbr>r1=310381&r2=310382&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/docs/ReleaseNotes.<wbr>rst (original)<br>
+++ cfe/trunk/docs/ReleaseNotes.<wbr>rst Tue Aug 8 10:09:09
2017<br>
@@ -94,6 +94,9 @@ Clang now supports the ...<br>
Attribute Changes in Clang<br>
--------------------------<br>
<br>
+- The presence of __attribute__((availability(..<wbr>.)))
on a declaration no longer<br>
+ implies default visibility for that declaration on macOS.<br>
+<br>
- ...<br>
<br>
Windows Support<br>
<br>
Modified: cfe/trunk/lib/AST/Decl.cpp<br>
URL: <a
href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/Decl.cpp?rev=310382&r1=310381&r2=310382&view=diff"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/lib/AST/<wbr>Decl.cpp?rev=310382&r1=310381&<wbr>r2=310382&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/lib/AST/Decl.cpp (original)<br>
+++ cfe/trunk/lib/AST/Decl.cpp Tue Aug 8 10:09:09 2017<br>
@@ -216,14 +216,6 @@ static Optional<Visibility>
getVisibilit<br>
return getVisibilityFromAttr(A);<br>
}<br>
<br>
- // If we're on Mac OS X, an 'availability' for Mac OS X
attribute<br>
- // implies visibility(default).<br>
- if (D->getASTContext().<wbr>getTargetInfo().getTriple().<wbr>isOSDarwin())
{<br>
- for (const auto *A : D->specific_attrs<<wbr>AvailabilityAttr>())<br>
- if (A->getPlatform()->getName().<wbr>equals("macos"))<br>
- return DefaultVisibility;<br>
- }<br>
-<br>
return None;<br>
}<br>
<br>
<br>
Modified: cfe/trunk/test/CodeGen/attr-<wbr>availability.c<br>
URL: <a
href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/attr-availability.c?rev=310382&r1=310381&r2=310382&view=diff"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/test/<wbr>CodeGen/attr-availability.c?<wbr>rev=310382&r1=310381&r2=<wbr>310382&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/test/CodeGen/attr-<wbr>availability.c
(original)<br>
+++ cfe/trunk/test/CodeGen/attr-<wbr>availability.c Tue Aug
8 10:09:09 2017<br>
@@ -8,9 +8,9 @@<br>
void f2();<br>
void f2() { }<br>
<br>
-// CHECK-10_4-LABEL: define void @f3<br>
-// CHECK-10_5-LABEL: define void @f3<br>
-// CHECK-10_6-LABEL: define void @f3<br>
+// CHECK-10_4-LABEL: define hidden void @f3<br>
+// CHECK-10_5-LABEL: define hidden void @f3<br>
+// CHECK-10_6-LABEL: define hidden void @f3<br>
void f3() __attribute__((availability(<wbr>macosx,introduced=10.5)));<br>
void f3() { }<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org"
moz-do-not-send="true">cfe-commits@lists.llvm.org</a><br>
<a
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>