<div dir="ltr">Hi Hans, this fixes a bug you wanted to treat as a 5.0 release blocker, so should be ported to the branch :)</div><div class="gmail_extra"><br><div class="gmail_quote">On 10 August 2017 at 19:04, Richard Smith via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rsmith<br>
Date: Thu Aug 10 19:04:19 2017<br>
New Revision: 310691<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=310691&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=310691&view=rev</a><br>
Log:<br>
PR33489: A function-style cast to a deduced class template specialization type is type-dependent if it can't be resolved due to a type-dependent argument.<br>
<br>
Modified:<br>
    cfe/trunk/lib/AST/ExprCXX.cpp<br>
    cfe/trunk/test/SemaCXX/cxx1z-<wbr>class-template-argument-<wbr>deduction.cpp<br>
<br>
Modified: cfe/trunk/lib/AST/ExprCXX.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ExprCXX.cpp?rev=310691&r1=310690&r2=310691&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/lib/AST/<wbr>ExprCXX.cpp?rev=310691&r1=<wbr>310690&r2=310691&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/lib/AST/ExprCXX.cpp (original)<br>
+++ cfe/trunk/lib/AST/ExprCXX.cpp Thu Aug 10 19:04:19 2017<br>
@@ -1052,7 +1052,9 @@ CXXUnresolvedConstructExpr::<wbr>CXXUnresolve<br>
           :Type->getType()-><wbr>isRValueReferenceType()? VK_XValue<br>
           :VK_RValue),<br>
          OK_Ordinary,<br>
-         Type->getType()-><wbr>isDependentType(), true, true,<br>
+         Type->getType()-><wbr>isDependentType() ||<br>
+             Type->getType()-><wbr>getContainedDeducedType(),<br>
+         true, true,<br>
          Type->getType()-><wbr>containsUnexpandedParameterPac<wbr>k()),<br>
     Type(Type),<br>
     LParenLoc(LParenLoc),<br>
<br>
Modified: cfe/trunk/test/SemaCXX/cxx1z-<wbr>class-template-argument-<wbr>deduction.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/cxx1z-class-template-argument-deduction.cpp?rev=310691&r1=310690&r2=310691&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/test/<wbr>SemaCXX/cxx1z-class-template-<wbr>argument-deduction.cpp?rev=<wbr>310691&r1=310690&r2=310691&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/test/SemaCXX/cxx1z-<wbr>class-template-argument-<wbr>deduction.cpp (original)<br>
+++ cfe/trunk/test/SemaCXX/cxx1z-<wbr>class-template-argument-<wbr>deduction.cpp Thu Aug 10 19:04:19 2017<br>
@@ -286,6 +286,29 @@ namespace tuple_tests {<br>
   }<br>
 }<br>
<br>
+namespace dependent {<br>
+  template<typename T> struct X {<br>
+    X(T);<br>
+  };<br>
+  template<typename T> int Var(T t) {<br>
+    X x(t);<br>
+    return X(x) + 1; // expected-error {{invalid operands}}<br>
+  }<br>
+  template<typename T> int Cast(T t) {<br>
+    return X(X(t)) + 1; // expected-error {{invalid operands}}<br>
+  }<br>
+  template<typename T> int New(T t) {<br>
+    return X(new X(t)) + 1; // expected-error {{invalid operands}}<br>
+  };<br>
+  template int Var(float); // expected-note {{instantiation of}}<br>
+  template int Cast(float); // expected-note {{instantiation of}}<br>
+  template int New(float); // expected-note {{instantiation of}}<br>
+  template<typename T> int operator+(X<T>, int);<br>
+  template int Var(int);<br>
+  template int Cast(int);<br>
+  template int New(int);<br>
+}<br>
+<br>
 #else<br>
<br>
 // expected-no-diagnostics<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>