<div dir="ltr">There's also `C::x; // 2` below, so I'd add this comment back at least for consistency.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 10, 2017 at 5:53 PM, Gábor Horváth <span dir="ltr"><<a href="mailto:xazax.hun@gmail.com" target="_blank">xazax.hun@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On 10 August 2017 at 17:40, Alexander Kornienko <span dir="ltr"><<a href="mailto:alexfh@google.com" target="_blank">alexfh@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 10, 2017 at 11:13 AM, Gabor Horvath via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: xazax<br>
Date: Thu Aug 10 02:13:26 2017<br>
New Revision: 310559<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=310559&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=310559&view=rev</a><br>
Log:<br>
[clang-tidy] Minor documentation improvement<br>
<br>
Patch by: Lilla Barancsuk<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/docs/c<wbr>lang-tidy/checks/readability-s<wbr>tatic-accessed-through-instanc<wbr>e.rst<br>
    clang-tools-extra/trunk/test/c<wbr>lang-tidy/readability-static-a<wbr>ccessed-through-instance.cpp<br>
<br>
Modified: clang-tools-extra/trunk/docs/c<wbr>lang-tidy/checks/readability-s<wbr>tatic-accessed-through-instanc<wbr>e.rst<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/readability-static-accessed-through-instance.rst?rev=310559&r1=310558&r2=310559&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/clang-tools-extra/trunk/<wbr>docs/clang-tidy/checks/readabi<wbr>lity-static-accessed-through-i<wbr>nstance.rst?rev=310559&r1=3105<wbr>58&r2=310559&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- clang-tools-extra/trunk/docs/c<wbr>lang-tidy/checks/readability-s<wbr>tatic-accessed-through-instanc<wbr>e.rst (original)<br>
+++ clang-tools-extra/trunk/docs/c<wbr>lang-tidy/checks/readability-s<wbr>tatic-accessed-through-instanc<wbr>e.rst Thu Aug 10 02:13:26 2017<br>
@@ -25,6 +25,7 @@ is changed to:<br>
<br>
 .. code-block:: c++<br>
<br>
+  C *c1 = new C();<br>
   C::foo();<br>
   C::x;<br>
<br>
<br>
Modified: clang-tools-extra/trunk/test/c<wbr>lang-tidy/readability-static-a<wbr>ccessed-through-instance.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/readability-static-accessed-through-instance.cpp?rev=310559&r1=310558&r2=310559&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/clang-tools-extra/trunk/<wbr>test/clang-tidy/readability-st<wbr>atic-accessed-through-instance<wbr>.cpp?rev=310559&r1=310558&r2=<wbr>310559&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- clang-tools-extra/trunk/test/c<wbr>lang-tidy/readability-static-a<wbr>ccessed-through-instance.cpp (original)<br>
+++ clang-tools-extra/trunk/test/c<wbr>lang-tidy/readability-static-a<wbr>ccessed-through-instance.cpp Thu Aug 10 02:13:26 2017<br>
@@ -116,7 +116,7 @@ using E = D;<br>
<br>
 template <typename T> void f(T t, C c) {<br>
   t.x; // OK, t is a template parameter.<br>
-  c.x; // 1<br>
+  c.x;<br></blockquote><div><br></div><div><span style="color:rgb(0,0,0);font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px">This comment was there to make the CHECK-FIXES line unique so that it doesn't match wrong line in the test. Any specific reason to remove it?</span></div></div></div></div></blockquote><div><br></div></div></div><div>There was no specific reason, this seemed to be redundant, and reducing readability. But I just noticed there is a <span class="m_-5256288125767630907gmail-pl-c">  C::x; line far above, so it looks like this was not redundant at all. Should I add this back or you are fine with leaving it as is for now? <br></span></div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><span style="color:rgb(0,0,0);font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px"></span> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
   // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: static member<br>
   // CHECK-FIXES: {{^}}  C::x; // 1{{$}}<br>
 }<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>
</blockquote></span></div><br></div></div>
</blockquote></div><br></div>