<div dir="auto">Should clang warn if you request static libc++ on fuchsia? It now silently ignores the flag, right?</div><div class="gmail_extra"><br><div class="gmail_quote">On Aug 1, 2017 9:18 PM, "Petr Hosek via Phabricator via cfe-commits" <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL309778: [Driver] Disable static C++ library support on Fuchsia (authored by phosek).<br>
<br>
Changed prior to commit:<br>
  <a href="https://reviews.llvm.org/D36202?vs=109255&id=109258#toc" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D36202?vs=109255&id=109258#toc</a><br>
<div class="quoted-text"><br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D36202" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D36202</a><br>
<br>
Files:<br>
</div>  cfe/trunk/cmake/caches/<wbr>Fuchsia-stage2.cmake<br>
  cfe/trunk/lib/Driver/<wbr>ToolChains/Fuchsia.cpp<br>
  cfe/trunk/test/Driver/fuchsia.<wbr>cpp<br>
<br>
<br>
Index: cfe/trunk/lib/Driver/<wbr>ToolChains/Fuchsia.cpp<br>
==============================<wbr>==============================<wbr>=======<br>
--- cfe/trunk/lib/Driver/<wbr>ToolChains/Fuchsia.cpp<br>
+++ cfe/trunk/lib/Driver/<wbr>ToolChains/Fuchsia.cpp<br>
<div class="quoted-text">@@ -107,15 +107,8 @@<br>
       CmdArgs.push_back("-Bdynamic")<wbr>;<br>
<br>
     if (D.CCCIsCXX()) {<br>
-      if (ToolChain.<wbr>ShouldLinkCXXStdlib(Args)) {<br>
-        bool OnlyLibstdcxxStatic = Args.hasArg(options::OPT_<wbr>static_libstdcxx) &&<br>
-                                   !Args.hasArg(options::OPT_<wbr>static);<br>
-        if (OnlyLibstdcxxStatic)<br>
-          CmdArgs.push_back("-Bstatic");<br>
+      if (ToolChain.<wbr>ShouldLinkCXXStdlib(Args))<br>
         ToolChain.AddCXXStdlibLibArgs(<wbr>Args, CmdArgs);<br>
-        if (OnlyLibstdcxxStatic)<br>
-          CmdArgs.push_back("-Bdynamic")<wbr>;<br>
-      }<br>
       CmdArgs.push_back("-lm");<br>
     }<br>
<br>
</div>Index: cfe/trunk/cmake/caches/<wbr>Fuchsia-stage2.cmake<br>
==============================<wbr>==============================<wbr>=======<br>
--- cfe/trunk/cmake/caches/<wbr>Fuchsia-stage2.cmake<br>
+++ cfe/trunk/cmake/caches/<wbr>Fuchsia-stage2.cmake<br>
<div class="quoted-text">@@ -31,6 +31,7 @@<br>
   set(BUILTINS_${target}-<wbr>fuchsia_CMAKE_SYSROOT ${FUCHSIA_${target}_SYSROOT} CACHE PATH "")<br>
   set(BUILTINS_${target}-<wbr>fuchsia_CMAKE_SYSTEM_NAME Fuchsia CACHE STRING "")<br>
 endforeach()<br>
+<br>
 if(NOT APPLE)<br>
   list(APPEND LLVM_BUILTIN_TARGETS "default")<br>
 endif()<br>
@@ -45,8 +46,10 @@<br>
   set(RUNTIMES_${target}-<wbr>fuchsia_LIBUNWIND_USE_<wbr>COMPILER_RT ON CACHE BOOL "")<br>
   set(RUNTIMES_${target}-<wbr>fuchsia_LIBCXXABI_USE_<wbr>COMPILER_RT ON CACHE BOOL "")<br>
   set(RUNTIMES_${target}-<wbr>fuchsia_LIBCXXABI_USE_LLVM_<wbr>UNWINDER ON CACHE BOOL "")<br>
+  set(RUNTIMES_${target}-<wbr>fuchsia_LIBCXXABI_ENABLE_<wbr>STATIC OFF CACHE BOOL "")<br>
   set(RUNTIMES_${target}-<wbr>fuchsia_LIBCXX_USE_COMPILER_RT ON CACHE BOOL "")<br>
   set(RUNTIMES_${target}-<wbr>fuchsia_LIBCXX_ABI_VERSION 2 CACHE STRING "")<br>
+  set(RUNTIMES_${target}-<wbr>fuchsia_LIBCXX_ENABLE_STATIC OFF CACHE BOOL "")<br>
 endforeach()<br>
<br>
 # Setup toolchain.<br>
</div>Index: cfe/trunk/test/Driver/fuchsia.<wbr>cpp<br>
==============================<wbr>==============================<wbr>=======<br>
--- cfe/trunk/test/Driver/fuchsia.<wbr>cpp<br>
+++ cfe/trunk/test/Driver/fuchsia.<wbr>cpp<br>
<div class="elided-text">@@ -28,8 +28,8 @@<br>
<br>
 // RUN: %clangxx %s -### --target=x86_64-unknown-<wbr>fuchsia -static-libstdc++ 2>&1 \<br>
 // RUN:     | FileCheck %s -check-prefix=CHECK-STATIC<br>
-// CHECK-STATIC: "-Bstatic"<br>
+// CHECK-STATIC-NOT: "-Bstatic"<br>
 // CHECK-STATIC: "-lc++" "-lc++abi" "-lunwind"<br>
-// CHECK-STATIC: "-Bdynamic"<br>
+// CHECK-STATIC-NOT: "-Bdynamic"<br>
 // CHECK-STATIC: "-lm"<br>
 // CHECK-STATIC: "-lc"<br>
<br>
<br>
</div><br>______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>