<div dir="ltr">It'd be good if this could go in today. ubsanvptr has been broken for us for a while now.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 31, 2017 at 4:43 PM, Vedant Kumar via Phabricator via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">vsk created this revision.<br>
<br>
In r309007, I made -fsanitize=null a hard prerequisite for -fsanitize=vptr. I did not see the need for the two checks to have separate null checking logic for the same pointer. I expected the two checks to either always be enabled together, or to be mutually compatible.<br>
<br>
In the mailing list discussion re: r309007 it became clear that that isn't the case. If a codebase is -fsanitize=vptr clean but not -fsanitize=null clean, it's useful to have -fsanitize=vptr emit its own null check. That's what this patch does: with it, -fsanitize=vptr can be used without -fsanitize=null.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D36112" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D36112</a><br>
<br>
Files:<br>
  docs/ReleaseNotes.rst<br>
  docs/<wbr>UndefinedBehaviorSanitizer.rst<br>
  include/clang/Basic/<wbr>DiagnosticDriverKinds.td<br>
  lib/CodeGen/CGExpr.cpp<br>
  lib/Driver/SanitizerArgs.cpp<br>
  test/CodeGenCXX/catch-undef-<wbr>behavior.cpp<br>
  test/CodeGenCXX/ubsan-type-<wbr>checks.cpp<br>
  test/Driver/fsanitize.c<br>
  test/Driver/rtti-options.cpp<br>
<br>
<br>______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>