<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Alex is in a different time zone, so he may not get to this today.<div class=""><br class=""></div><div class="">Do you have the time to give a review?</div><div class=""><br class=""></div><div class=""><div><blockquote type="cite" class=""><div class="">On Aug 1, 2017, at 12:38 PM, Nico Weber <<a href="mailto:thakis@chromium.org" class="">thakis@chromium.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">It'd be good if this could go in today. ubsanvptr has been broken for us for a while now.</div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Mon, Jul 31, 2017 at 4:43 PM, Vedant Kumar via Phabricator via cfe-commits <span dir="ltr" class=""><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">vsk created this revision.<br class="">
<br class="">
In r309007, I made -fsanitize=null a hard prerequisite for -fsanitize=vptr. I did not see the need for the two checks to have separate null checking logic for the same pointer. I expected the two checks to either always be enabled together, or to be mutually compatible.<br class="">
<br class="">
In the mailing list discussion re: r309007 it became clear that that isn't the case. If a codebase is -fsanitize=vptr clean but not -fsanitize=null clean, it's useful to have -fsanitize=vptr emit its own null check. That's what this patch does: with it, -fsanitize=vptr can be used without -fsanitize=null.<br class="">
<br class="">
<br class="">
<a href="https://reviews.llvm.org/D36112" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/<wbr class="">D36112</a><br class="">
<br class="">
Files:<br class="">
docs/ReleaseNotes.rst<br class="">
docs/<wbr class="">UndefinedBehaviorSanitizer.rst<br class="">
include/clang/Basic/<wbr class="">DiagnosticDriverKinds.td<br class="">
lib/CodeGen/CGExpr.cpp<br class="">
lib/Driver/SanitizerArgs.cpp<br class="">
test/CodeGenCXX/catch-undef-<wbr class="">behavior.cpp<br class="">
test/CodeGenCXX/ubsan-type-<wbr class="">checks.cpp<br class="">
test/Driver/fsanitize.c<br class="">
test/Driver/rtti-options.cpp<br class="">
<br class="">
<br class="">______________________________<wbr class="">_________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/cfe-commits</a><br class="">
<br class=""></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>