<div dir="ltr">Test coverage?</div><br><div class="gmail_quote"><div dir="ltr">On Sun, Jul 30, 2017 at 5:52 AM Lenar Safin via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: lll<br>
Date: Sat Jul 29 13:42:58 2017<br>
New Revision: 309496<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=309496&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=309496&view=rev</a><br>
Log:<br>
Improve readability of CXX method overrides list<br>
<br>
Summary:<br>
Separate CXX method overrides list entries with commas.<br>
<br>
Reviewers: lhames<br>
<br>
Reviewed By: lhames<br>
<br>
Subscribers: llvm-commits<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D35800" rel="noreferrer" target="_blank">https://reviews.llvm.org/D35800</a><br>
<br>
<br>
Modified:<br>
    cfe/trunk/lib/AST/ASTDumper.cpp<br>
<br>
Modified: cfe/trunk/lib/AST/ASTDumper.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTDumper.cpp?rev=309496&r1=309495&r2=309496&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTDumper.cpp?rev=309496&r1=309495&r2=309496&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/AST/ASTDumper.cpp (original)<br>
+++ cfe/trunk/lib/AST/ASTDumper.cpp Sat Jul 29 13:42:58 2017<br>
@@ -1184,7 +1184,7 @@ void ASTDumper::VisitFunctionDecl(const<br>
          I != E; ++I)<br>
       dumpCXXCtorInitializer(*I);<br>
<br>
-  if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(D))<br>
+  if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(D)) {<br>
     if (MD->size_overridden_methods() != 0) {<br>
       auto dumpOverride =<br>
         [=](const CXXMethodDecl *D) {<br>
@@ -1199,11 +1199,14 @@ void ASTDumper::VisitFunctionDecl(const<br>
         dumpOverride(*FirstOverrideItr);<br>
         for (const auto *Override :<br>
                llvm::make_range(FirstOverrideItr + 1,<br>
-                                MD->end_overridden_methods()))<br>
+                                MD->end_overridden_methods())) {<br>
+          OS << ", ";<br>
           dumpOverride(Override);<br>
+        }<br>
         OS << " ]";<br>
       });<br>
     }<br>
+  }<br>
<br>
   if (D->doesThisDeclarationHaveABody())<br>
     dumpStmt(D->getBody());<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>