<div dir="ltr">Thanks, I'll take a look.</div><div class="gmail_extra"><br><div class="gmail_quote">On 19 July 2017 at 13:31, Hans Wennborg <span dir="ltr"><<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Wed, Jul 19, 2017 at 2:26 PM, Hans Wennborg <<a href="mailto:hans@chromium.org">hans@chromium.org</a>> wrote:<br>
> On Wed, Jul 19, 2017 at 1:30 PM, Alex Lorenz via cfe-commits<br>
> <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
>> Author: arphaman<br>
>> Date: Wed Jul 19 04:30:41 2017<br>
>> New Revision: 308441<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=308441&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=308441&view=rev</a><br>
>> Log:<br>
>> Recommit r308327: Add a warning for missing '#pragma pack (pop)'<br>
>> and suspicious uses of '#pragma pack' in included files<br>
>><br>
>> This commit adds a new -Wpragma-pack warning. It warns in the following cases:<br>
>><br>
>> - When a translation unit is missing terminating #pragma pack (pop) directives.<br>
>> - When entering an included file if the current alignment value as determined<br>
>>   by '#pragma pack' directives is different from the default alignment value.<br>
>> - When leaving an included file that changed the state of the current alignment<br>
>>   value.<br>
>><br>
>> rdar://10184173<br>
>><br>
>> Differential Revision: <a href="https://reviews.llvm.org/D35484" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D35484</a><br>
><br>
> This buildbot is unhappy:<br>
> <a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/2963" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/sanitizer-x86_64-<wbr>linux/builds/2963</a><br>
><br>
> From the build log:<br>
><br>
> [ 67%] Building CXX object<br>
> lib/Passes/CMakeFiles/<wbr>LLVMPasses.dir/PassBuilder.<wbr>cpp.o<br>
> In file included from<br>
> /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm/lib/ProfileData/Coverage/<wbr>CoverageMappingWriter.cpp:15:<br>
> In file included from<br>
> /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm/include/llvm/ProfileData/<wbr>Coverage/<wbr>CoverageMappingWriter.h:20:<br>
> /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm/include/llvm/ProfileData/<wbr>Coverage/CoverageMapping.h:<wbr>517:10:<br>
> error: non-default #pragma pack value might change the alignment of<br>
> struct or union members in the included file [-Werror,-Wpragma-pack]<br>
> #include "llvm/ProfileData/<wbr>InstrProfData.inc"<br>
>          ^<br>
> /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm/include/llvm/ProfileData/<wbr>Coverage/CoverageMapping.h:<wbr>513:1:<br>
> note: previous '#pragma pack' directive that modifies alignment is<br>
> here<br>
> LLVM_PACKED_START<br>
> ^<br>
> /mnt/b/sanitizer-buildbot1/<wbr>sanitizer-x86_64-linux/build/<wbr>llvm/include/llvm/Support/<wbr>Compiler.h:349:28:<br>
> note: expanded from macro 'LLVM_PACKED_START'<br>
> # define LLVM_PACKED_START _Pragma("pack(push, 1)")<br>
>                            ^<br>
> <scratch space>:14:2: note: expanded from here<br>
>  pack(push, 1)<br>
>  ^<br>
<br>
</div></div>I've reverted in r308455 in the meantime.<br>
</blockquote></div><br></div>