<div dir="ltr">Thx. Submitted as r308185.</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jul 17, 2017 at 4:28 PM Erik Uhlmann <<a href="mailto:euhlmann@vmware.com">euhlmann@vmware.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">







<div bgcolor="white" lang="EN-US" link="blue" vlink="purple">
<div class="m_172333202699822268WordSection1">
<p class="MsoNormal">I don’t have commit access, so I’d need you to check it in. Thanks for your help!<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">Manuel Klimek <<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>><br>
<b>Date: </b>Monday, July 17, 2017 at 03:31<br>
<b>To: </b>Erik Uhlmann <<a href="mailto:euhlmann@vmware.com" target="_blank">euhlmann@vmware.com</a>>, "<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>" <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>><br>
<b>Subject: </b>Re: clang-format: Fix deref treated as binary op in throw<u></u><u></u></span></p>
</div></div></div><div bgcolor="white" lang="EN-US" link="blue" vlink="purple"><div class="m_172333202699822268WordSection1">
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">LG, thanks for the patch. For next time, it helps to use phabricator to make people catch patches faster :)
<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Do you have commit access or do you need me to check it in?<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Thu, Jul 6, 2017 at 6:53 PM Erik Uhlmann via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">When dereferencing a pointer in a throw statement, clang-format assigns TT_BinaryOperator to the star token, so it gets formatted as:<br>
<br>
throw * x;<br>
<br>
With this change the above becomes<br>
<br>
throw *x;<br>
<br>
Bug tracker: <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.llvm.org_show-5Fbug.cgi-3Fid-3D33665&d=DwMFaQ&c=uilaK90D4TOVoH58JNXRgQ&r=1oNaO28yAR9wl4tZt0TtaPSmNktwFks9KPTlhdWuPig&m=JCauKpC86D0ab4DIjW5ueRu088U8_cBuoizilFN8b_s&s=3S0gX68mvOabDGdTODcMBbmYJB4pHnUzRN3mNNwVGzc&e=" target="_blank">
https://bugs.llvm.org/show_bug.cgi?id=33665</a><br>
<br>
Attached is a patch containing the fix.<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=DwMFaQ&c=uilaK90D4TOVoH58JNXRgQ&r=1oNaO28yAR9wl4tZt0TtaPSmNktwFks9KPTlhdWuPig&m=JCauKpC86D0ab4DIjW5ueRu088U8_cBuoizilFN8b_s&s=TfTlgUj10Yo0COkFwEotZwRfb7Z5DnI_f8ENR3mpd3k&e=" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><u></u><u></u></p>
</blockquote>
</div>
</div></div></blockquote></div>