<div dir="ltr">FWIW, I think you could just give the enum an explicit underlying type of size_type.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 11, 2017 at 6:45 PM, Ben Craig via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: bcraig<br>
Date: Tue Jul 11 18:45:13 2017<br>
New Revision: 307751<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=307751&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=307751&view=rev</a><br>
Log:<br>
Fix unrepresentable enum for clang-cl unstable ABI<br>
<br>
When using LIBCXX_ABI_UNSTABLE=YES, clang-cl gave the following warning:<br>
<br>
P:\llvm_master\src\llvm\<wbr>projects\libcxx\include\<wbr>string(683,51):<br>
warning: enumerator value is not representable in the underlying type<br>
'int' [-Wmicrosoft-enum-value]<br>
<br>
Fixed by switching from enums to static const size_type.<br>
<br>
<a href="https://reviews.llvm.org/D35174" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D35174</a><br>
<br>
Modified:<br>
    libcxx/trunk/include/string<br>
<br>
Modified: libcxx/trunk/include/string<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/string?rev=307751&r1=307750&r2=307751&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/libcxx/trunk/include/<wbr>string?rev=307751&r1=307750&<wbr>r2=307751&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/include/string (original)<br>
+++ libcxx/trunk/include/string Tue Jul 11 18:45:13 2017<br>
@@ -676,11 +676,11 @@ private:<br>
     };<br>
<br>
 #if _LIBCPP_BIG_ENDIAN<br>
-    enum {__short_mask = 0x01};<br>
-    enum {__long_mask  = 0x1ul};<br>
+    static const size_type __short_mask = 0x01;<br>
+    static const size_type __long_mask  = 0x1ul;<br>
 #else  // _LIBCPP_BIG_ENDIAN<br>
-    enum {__short_mask = 0x80};<br>
-    enum {__long_mask  = ~(size_type(~0) >> 1)};<br>
+    static const size_type __short_mask = 0x80;<br>
+    static const size_type __long_mask  = ~(size_type(~0) >> 1);<br>
 #endif  // _LIBCPP_BIG_ENDIAN<br>
<br>
     enum {__min_cap = (sizeof(__long) - 1)/sizeof(value_type) > 2 ?<br>
@@ -706,11 +706,11 @@ private:<br>
     };<br>
<br>
 #if _LIBCPP_BIG_ENDIAN<br>
-    enum {__short_mask = 0x80};<br>
-    enum {__long_mask  = ~(size_type(~0) >> 1)};<br>
+    static const size_type __short_mask = 0x80;<br>
+    static const size_type __long_mask  = ~(size_type(~0) >> 1);<br>
 #else  // _LIBCPP_BIG_ENDIAN<br>
-    enum {__short_mask = 0x01};<br>
-    enum {__long_mask  = 0x1ul};<br>
+    static const size_type __short_mask = 0x01;<br>
+    static const size_type __long_mask  = 0x1ul;<br>
 #endif  // _LIBCPP_BIG_ENDIAN<br>
<br>
     enum {__min_cap = (sizeof(__long) - 1)/sizeof(value_type) > 2 ?<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>