<div dir="ltr">Which compiler/what warning was flagging this?<br><br>It doesn't look like Clang builds by default with -Wconditional-uninitialized on, so I'm surprised if Clang was diagnosing anything here.<br><br>In any case - it's probably better to omit the "WasAmbiguous" flag. Optional already has a flag that says whether it has a value, so either you can rely on that or assert against it explicitly:<br><br>  assert(SavedAK);<br>  Ambiguity = *SavedAK;<br><br>But I'd probably skip adding the assertion here - especially since it currently doesn't have a message, so it's probably no better than the assert that Optional's operator* will do anyway.</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Jun 30, 2017 at 2:25 AM Vassil Vassilev via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: vvassilev<br>
Date: Fri Jun 30 02:25:43 2017<br>
New Revision: 306809<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=306809&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=306809&view=rev</a><br>
Log:<br>
Ambiguity might be also uninitialized. Use llvm::Optional.<br>
<br>
<br>
Modified:<br>
    cfe/trunk/include/clang/Sema/Lookup.h<br>
<br>
Modified: cfe/trunk/include/clang/Sema/Lookup.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/Lookup.h?rev=306809&r1=306808&r2=306809&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/Lookup.h?rev=306809&r1=306808&r2=306809&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Sema/Lookup.h (original)<br>
+++ cfe/trunk/include/clang/Sema/Lookup.h Fri Jun 30 02:25:43 2017<br>
@@ -18,6 +18,8 @@<br>
 #include "clang/AST/DeclCXX.h"<br>
 #include "clang/Sema/Sema.h"<br>
<br>
+#include "llvm/ADT/Optional.h"<br>
+<br>
 namespace clang {<br>
<br>
 /// @brief Represents the results of name lookup.<br>
@@ -465,9 +467,10 @@ public:<br>
         Paths = nullptr;<br>
       }<br>
     } else {<br>
-      AmbiguityKind SavedAK = Ambiguity;<br>
+      llvm::Optional<AmbiguityKind> SavedAK;<br>
       bool WasAmbiguous = false;<br>
       if (ResultKind == Ambiguous) {<br>
+        SavedAK = Ambiguity;<br>
         WasAmbiguous = true;<br>
       }<br>
       ResultKind = Found;<br>
@@ -478,7 +481,7 @@ public:<br>
       if (ResultKind == Ambiguous) {<br>
         (void)WasAmbiguous;<br>
         assert(WasAmbiguous);<br>
-        Ambiguity = SavedAK;<br>
+        Ambiguity = SavedAK.getValue();<br>
       } else if (Paths) {<br>
         deletePaths(Paths);<br>
         Paths = nullptr;<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>