<div dir="ltr">Does this test any code in Clang? (given the test is being committed without any change in Clang, I'm guessing maybe not) - perhaps this test doesn't belong in Clang's test suite?<br><br>Looks like changes/functionality in LTOPreLinkDefaultPipeline are tested in test/Other/new-pm-thinlto-defaults.ll at least?<br><br><div class="gmail_quote"><div dir="ltr">On Fri, Jun 30, 2017 at 10:05 AM Dehao Chen via Phabricator via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">danielcdh created this revision.<br>
Herald added subscribers: eraman, inglorion, mehdi_amini, sanjoy.<br>
<br>
This patch should be enabled after <a href="https://reviews.llvm.org/D34895" rel="noreferrer" target="_blank">https://reviews.llvm.org/D34895</a><br>
<br>
<br>
<a href="https://reviews.llvm.org/D34896" rel="noreferrer" target="_blank">https://reviews.llvm.org/D34896</a><br>
<br>
Files:<br>
  test/CodeGen/pgo-sample-thinlto-summary.c<br>
<br>
<br>
Index: test/CodeGen/pgo-sample-thinlto-summary.c<br>
===================================================================<br>
--- test/CodeGen/pgo-sample-thinlto-summary.c<br>
+++ test/CodeGen/pgo-sample-thinlto-summary.c<br>
@@ -1,9 +1,7 @@<br>
 // RUN: %clang_cc1 -O2 -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -o - 2>&1 | FileCheck %s -check-prefix=SAMPLEPGO<br>
 // RUN: %clang_cc1 -O2 -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -flto=thin -o - 2>&1 | FileCheck %s -check-prefix=THINLTO<br>
 // RUN: %clang_cc1 -O2 -fexperimental-new-pass-manager -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -o - 2>&1 | FileCheck %s -check-prefix=SAMPLEPGO<br>
-// FIXME: Run the following command once LTOPreLinkDefaultPipeline is<br>
-//        customized.<br>
-// %clang_cc1 -O2 -fexperimental-new-pass-manager -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -flto=thin -o - 2>&1 | FileCheck %s -check-prefix=THINLTO<br>
+// RUN: %clang_cc1 -O2 -fexperimental-new-pass-manager -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -flto=thin -o - 2>&1 | FileCheck %s -check-prefix=THINLTO<br>
 // Checks if hot call is inlined by normal compile, but not inlined by<br>
 // thinlto compile.<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div>