<div dir="auto">This is even an error in VS2017, I've just fixed a number of instances of this in an internal codebase. <div dir="auto"><br></div><div dir="auto">- Kim </div></div><div class="gmail_extra"><br><div class="gmail_quote">Den 6 juni 2017 4:32 em skrev "Alexander Kornienko via cfe-commits" <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>>:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Jun 5, 2017 at 7:11 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">what was the warning?</div></blockquote><div><br></div><div>I don't remember the exact warning text, but the idea was that a non-const operator() could not be called. The change is reasonable in any case: the operator() here has no reason to be non-const.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_-5429340291446062780HOEnZb"><div class="m_-5429340291446062780h5"><br><div class="gmail_quote"><div dir="ltr">On Fri, Jun 2, 2017 at 11:48 AM Alexander Kornienko via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: alexfh<br>
Date: Fri Jun  2 13:47:50 2017<br>
New Revision: 304583<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=304583&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=304583&view=rev</a><br>
Log:<br>
[clang-tidy] Add `const` to operator() to fix a warning.<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/clang-<wbr>tidy/misc/LambdaFunctionNameCh<wbr>eck.h<br>
<br>
Modified: clang-tools-extra/trunk/clang-<wbr>tidy/misc/LambdaFunctionNameCh<wbr>eck.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h?rev=304583&r1=304582&r2=304583&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/clang-tools-extra/trunk/<wbr>clang-tidy/misc/LambdaFunction<wbr>NameCheck.h?rev=304583&r1=<wbr>304582&r2=304583&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- clang-tools-extra/trunk/clang-<wbr>tidy/misc/LambdaFunctionNameCh<wbr>eck.h (original)<br>
+++ clang-tools-extra/trunk/clang-<wbr>tidy/misc/LambdaFunctionNameCh<wbr>eck.h Fri Jun  2 13:47:50 2017<br>
@@ -25,7 +25,7 @@ namespace misc {<br>
 class LambdaFunctionNameCheck : public ClangTidyCheck {<br>
 public:<br>
   struct SourceRangeLessThan {<br>
-    bool operator()(const SourceRange &L, const SourceRange &R) {<br>
+    bool operator()(const SourceRange &L, const SourceRange &R) const {<br>
       if (L.getBegin() == R.getBegin()) {<br>
         return L.getEnd() < R.getEnd();<br>
       }<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
</div></div></blockquote></div><br></div></div>
<br>______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div></div>