<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 30. Jun 2017, at 16:31, Erik Verbruggen via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On 23. Jun 2017, at 23:54, Richard Smith <<a href="mailto:richard@metafoo.co.uk" class="">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote">On 23 June 2017 at 13:34, Benjamin Kramer via cfe-commits <span dir="ltr" class=""><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Since this change went in I'm seeing spurious errors whenever editing<br class="">
a header file, filed <a href="https://bugs.llvm.org/show_bug.cgi?id=33574" rel="noreferrer" target="_blank" class="">https://bugs.llvm.org/show_<wbr class="">bug.cgi?id=33574</a> for<br class="">
that.</blockquote><div class=""><br class=""></div><div class="">Does fixing the reversed condition I pointed out fix that?</div></div></div></div></div></blockquote><br class=""></div><div class="">Nope. See <a href="https://reviews.llvm.org/D34882" class="">https://reviews.llvm.org/D34882</a> for a fix that passes the case mentioned in the bug report. I asked Benjamin on IRC if he could test that patch a bit. Will polish it up when it's I know if it introduces more/other problems.</div></div></div></blockquote><br class=""></div><div>Fix submitted as revision 307134.</div><div><br class=""></div><div>-- Erik</div><br class=""></body></html>