<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 30/06/17 01:03, Evgenii Stepanov
wrote:<br>
</div>
<blockquote
cite="mid:CABMLtrjySMAeMhfO_-uqNeZo_mygP25pGZuXK9AVYnLF156j-g@mail.gmail.com"
type="cite">
<div dir="ltr">This change broke clang/ubsan bot.
<div><a moz-do-not-send="true"
href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6047/steps/check-clang%20ubsan/logs/stdio">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6047/steps/check-clang%20ubsan/logs/stdio</a><br>
</div>
<div><br>
</div>
<div>It looks like the value you are initializing SavedAK with
may itself be uninitialized? I see a few constructors that do
not mention it.</div>
</div>
</blockquote>
Indeed. Do you have a solution in mind? The only way I see to fix
this is by using an llvm::Optional.<br>
<blockquote
cite="mid:CABMLtrjySMAeMhfO_-uqNeZo_mygP25pGZuXK9AVYnLF156j-g@mail.gmail.com"
type="cite">
<div dir="ltr">
<div><br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, Jun 29, 2017 at 9:08 AM, Vassil
Vassilev via cfe-commits <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Author:
vvassilev<br>
Date: Thu Jun 29 09:08:10 2017<br>
New Revision: 306692<br>
<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project?rev=306692&view=rev"
rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=306692&view=rev</a><br>
Log:<br>
Initialize variable and silence potentially uninitialized
warning.<br>
<br>
Patch by Liza Sakellari!<br>
<br>
Modified:<br>
cfe/trunk/include/clang/Sema/<wbr>Lookup.h<br>
<br>
Modified: cfe/trunk/include/clang/Sema/<wbr>Lookup.h<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/Lookup.h?rev=306692&r1=306691&r2=306692&view=diff"
rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/include/<wbr>clang/Sema/Lookup.h?rev=<wbr>306692&r1=306691&r2=306692&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/include/clang/Sema/<wbr>Lookup.h (original)<br>
+++ cfe/trunk/include/clang/Sema/<wbr>Lookup.h Thu Jun 29
09:08:10 2017<br>
@@ -465,10 +465,9 @@ public:<br>
Paths = nullptr;<br>
}<br>
} else {<br>
- AmbiguityKind SavedAK;<br>
+ AmbiguityKind SavedAK = Ambiguity;<br>
bool WasAmbiguous = false;<br>
if (ResultKind == Ambiguous) {<br>
- SavedAK = Ambiguity;<br>
WasAmbiguous = true;<br>
}<br>
ResultKind = Found;<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a moz-do-not-send="true"
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits"
rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<p><br>
</p>
</body>
</html>