<div dir="ltr">Hello Yan,<br><br>This commit broke few of our builders:<br><br>Failing Tests (1):<br>    Clang Tools :: clang-tidy/misc-noexcept-move-constructor.cpp<br><br><a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/12411">http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/12411</a><br><a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast">http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast</a><br><br>Please have a look at this?<br><br>Thanks<br><br>Galina<br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 7, 2017 at 3:39 PM, Yan Wang via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: yawanng<br>
Date: Wed Jun  7 17:39:20 2017<br>
New Revision: 304949<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=304949&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=304949&view=rev</a><br>
Log:<br>
[clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.<br>
<br>
Summary:  "misc-noexcept-move-<wbr>constructor" is better not to be issued when "-fno-exceptions" is set.<br>
<br>
Reviewers: chh, alexfh, aaron.ballman<br>
<br>
Reviewed By: aaron.ballman<br>
<br>
Subscribers: aaron.ballman, cfe-commits, xazax.hun<br>
<br>
Tags: #clang-tools-extra<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D34002" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D34002</a><br>
<br>
Modified:<br>
    clang-tools-extra/trunk/clang-<wbr>tidy/misc/<wbr>NoexceptMoveConstructorCheck.<wbr>cpp<br>
    clang-tools-extra/trunk/test/<wbr>clang-tidy/misc-noexcept-move-<wbr>constructor.cpp<br>
<br>
Modified: clang-tools-extra/trunk/clang-<wbr>tidy/misc/<wbr>NoexceptMoveConstructorCheck.<wbr>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/NoexceptMoveConstructorCheck.cpp?rev=304949&r1=304948&r2=304949&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/clang-tools-extra/<wbr>trunk/clang-tidy/misc/<wbr>NoexceptMoveConstructorCheck.<wbr>cpp?rev=304949&r1=304948&r2=<wbr>304949&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- clang-tools-extra/trunk/clang-<wbr>tidy/misc/<wbr>NoexceptMoveConstructorCheck.<wbr>cpp (original)<br>
+++ clang-tools-extra/trunk/clang-<wbr>tidy/misc/<wbr>NoexceptMoveConstructorCheck.<wbr>cpp Wed Jun  7 17:39:20 2017<br>
@@ -20,7 +20,7 @@ namespace misc {<br>
 void NoexceptMoveConstructorCheck::<wbr>registerMatchers(MatchFinder *Finder) {<br>
   // Only register the matchers for C++11; the functionality currently does not<br>
   // provide any benefit to other languages, despite being benign.<br>
-  if (!getLangOpts().CPlusPlus11)<br>
+  if (!getLangOpts().CPlusPlus11 || !getLangOpts().CXXExceptions)<br>
     return;<br>
<br>
   Finder->addMatcher(<br>
<br>
Modified: clang-tools-extra/trunk/test/<wbr>clang-tidy/misc-noexcept-move-<wbr>constructor.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/misc-noexcept-move-constructor.cpp?rev=304949&r1=304948&r2=304949&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/clang-tools-extra/<wbr>trunk/test/clang-tidy/misc-<wbr>noexcept-move-constructor.cpp?<wbr>rev=304949&r1=304948&r2=<wbr>304949&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- clang-tools-extra/trunk/test/<wbr>clang-tidy/misc-noexcept-move-<wbr>constructor.cpp (original)<br>
+++ clang-tools-extra/trunk/test/<wbr>clang-tidy/misc-noexcept-move-<wbr>constructor.cpp Wed Jun  7 17:39:20 2017<br>
@@ -1,16 +1,25 @@<br>
-// RUN: %check_clang_tidy %s misc-noexcept-move-constructor %t<br>
+// RUN: clang-tidy %s -checks="-*,misc-noexcept-<wbr>move-constructor" -- -std=c++11 \<br>
+// RUN:   | FileCheck %s -check-prefix=CHECK-EXCEPTIONS \<br>
+// RUN:   -implicit-check-not="{{<wbr>warning|error}}:"<br>
+// RUN: clang-tidy %s -checks="-*,misc-noexcept-<wbr>move-constructor" -- -fno-exceptions -std=c++11 \<br>
+// RUN:   | FileCheck %s -allow-empty -check-prefix=CHECK-<wbr>NONEXCEPTIONS \<br>
+// RUN:   -implicit-check-not="{{<wbr>warning|error}}:"<br>
+<br>
<br>
 class A {<br>
   A(A &&);<br>
-  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: move constructors should be marked noexcept [misc-noexcept-move-<wbr>constructor]<br>
+  // CHECK-EXCEPTIONS: :[[@LINE-1]]:3: warning: move constructors should be marked noexcept [misc-noexcept-move-<wbr>constructor]<br>
+  // CHECK-NONEXCEPTIONS-NOT: warning:<br>
   A &operator=(A &&);<br>
-  // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: move assignment operators should<br>
+  // CHECK-EXCEPTIONS: :[[@LINE-1]]:6: warning: move assignment operators should<br>
+  // CHECK-NONEXCEPTIONS-NOT: warning:<br>
 };<br>
<br>
 struct B {<br>
   static constexpr bool kFalse = false;<br>
   B(B &&) noexcept(kFalse);<br>
-  // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: noexcept specifier on the move constructor evaluates to 'false' [misc-noexcept-move-<wbr>constructor]<br>
+  // CHECK-EXCEPTIONS: :[[@LINE-1]]:20: warning: noexcept specifier on the move constructor evaluates to 'false' [misc-noexcept-move-<wbr>constructor]<br>
+  // CHECK-NONEXCEPTIONS-NOT: warning:<br>
 };<br>
<br>
 class OK {};<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>