<div dir="ltr">Cool. Thanks for checking.</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 2, 2017 at 1:12 PM, Vedant Kumar <span dir="ltr"><<a href="mailto:vsk@apple.com" target="_blank">vsk@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hm, sorry, the compiler on the bot could not have picked up r304518, so I jumped the gun here. I'll try again later and report back in PR33271.<br>
<span class="HOEnZb"><font color="#888888"><br>
vedant<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
> On Jun 2, 2017, at 1:09 PM, Vedant Kumar via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Hi Gor,<br>
><br>
> This is just a heads-up that I tried re-enabling ubsan for the two tests affected by PR33271, but saw some similar failures. The commit message below has more details about what was tested and what went wrong.<br>
><br>
> best,<br>
> vedant<br>
><br>
><br>
>> On Jun 2, 2017, at 1:06 PM, Vedant Kumar via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
>><br>
>> Author: vedantk<br>
>> Date: Fri Jun  2 15:06:49 2017<br>
>> New Revision: 304591<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=304591&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=304591&view=rev</a><br>
>> Log:<br>
>> Mark two coroutine tests as unsupported under ubsan, again<br>
>><br>
>> This reverts commit r304580, making bool_await_suspend.pass.cpp and<br>
>> generator.pass.cpp unsupported on ubsan again. The host compiler is<br>
>> based on r304329, which has the change from PR33271 (r304277). However,<br>
>> this was not enough to address the issue.<br>
>><br>
>> Bot Failure:<br>
>> <a href="http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-ubsan/builds/628" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/libcxx-libcxxabi-x86_<wbr>64-linux-ubuntu-ubsan/builds/<wbr>628</a><br>
>><br>
>> Unknown type!<br>
>> UNREACHABLE executed at /home/eric/full-llvm/llvm/lib/<wbr>IR/ValueTypes.cpp:287!<br>
>> llvm::EVT::getEVT(llvm::Type*, bool) (/usr/local/bin/clang-5.0+<wbr>0x17e7a07)<br>
>> llvm::TargetLoweringBase::<wbr>getValueType(llvm::DataLayout const&, llvm::Type*, bool) const (/usr/local/bin/clang-5.0+<wbr>0x852c4a)<br>
>> llvm::ComputeValueVTs(llvm::<wbr>TargetLowering const&, llvm::DataLayout const&, llvm::Type*, llvm::SmallVectorImpl<llvm::<wbr>EVT>&, llvm::SmallVectorImpl<unsigned long>*, unsigned long) (/usr/local/bin/clang-5.0+<wbr>0x141b6e9)<br>
>> llvm::SelectionDAGBuilder::<wbr>visitTargetIntrinsic(llvm::<wbr>CallInst const&, unsigned int) (/usr/local/bin/clang-5.0+<wbr>0x237b1ca)<br>
>><br>
>> clang-5.0: /home/eric/full-llvm/llvm/lib/<wbr>CodeGen/AsmPrinter/DwarfDebug.<wbr>cpp:1236: virtual void llvm::DwarfDebug::<wbr>endFunctionImpl(const llvm::MachineFunction *): Assertion `LScopes.<wbr>getAbstractScopesList().size() == NumAbstractScopes && "<wbr>ensureAbstractVariableIsCreate<wbr>d inserted abstract scopes"' failed.<br>
>> __assert_fail_base /build/glibc-9tT8Do/glibc-2.<wbr>23/assert/assert.c:92:0<br>
>> (/lib/x86_64-linux-gnu/libc.<wbr>so.6+0x2dc82)<br>
>> llvm::DwarfDebug::<wbr>endFunctionImpl(llvm::<wbr>MachineFunction const*) (/usr/local/bin/clang-5.0+<wbr>0x223f86b)<br>
>> llvm::DebugHandlerBase::<wbr>endFunction(llvm::<wbr>MachineFunction const*) (/usr/local/bin/clang-5.0+<wbr>0x227a5a1)<br>
>> llvm::AsmPrinter::<wbr>EmitFunctionBody() (/usr/local/bin/clang-5.0+<wbr>0x222522f)<br>
>><br>
>> Modified:<br>
>>   libcxx/trunk/test/std/<wbr>experimental/language.support/<wbr>support.coroutines/end.to.end/<wbr>bool_await_suspend.pass.cpp<br>
>>   libcxx/trunk/test/std/<wbr>experimental/language.support/<wbr>support.coroutines/end.to.end/<wbr>generator.pass.cpp<br>
>><br>
>> Modified: libcxx/trunk/test/std/<wbr>experimental/language.support/<wbr>support.coroutines/end.to.end/<wbr>bool_await_suspend.pass.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/bool_await_suspend.pass.cpp?rev=304591&r1=304590&r2=304591&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/libcxx/trunk/test/std/<wbr>experimental/language.support/<wbr>support.coroutines/end.to.end/<wbr>bool_await_suspend.pass.cpp?<wbr>rev=304591&r1=304590&r2=<wbr>304591&view=diff</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- libcxx/trunk/test/std/<wbr>experimental/language.support/<wbr>support.coroutines/end.to.end/<wbr>bool_await_suspend.pass.cpp (original)<br>
>> +++ libcxx/trunk/test/std/<wbr>experimental/language.support/<wbr>support.coroutines/end.to.end/<wbr>bool_await_suspend.pass.cpp Fri Jun  2 15:06:49 2017<br>
>> @@ -10,6 +10,9 @@<br>
>><br>
>> // UNSUPPORTED: c++98, c++03, c++11<br>
>><br>
>> +// See <a href="https://bugs.llvm.org/show_bug.cgi?id=33271" rel="noreferrer" target="_blank">https://bugs.llvm.org/show_<wbr>bug.cgi?id=33271</a><br>
>> +// UNSUPPORTED: ubsan<br>
>> +<br>
>> #include <experimental/coroutine><br>
>> #include <cassert><br>
>><br>
>><br>
>> Modified: libcxx/trunk/test/std/<wbr>experimental/language.support/<wbr>support.coroutines/end.to.end/<wbr>generator.pass.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/generator.pass.cpp?rev=304591&r1=304590&r2=304591&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/libcxx/trunk/test/std/<wbr>experimental/language.support/<wbr>support.coroutines/end.to.end/<wbr>generator.pass.cpp?rev=304591&<wbr>r1=304590&r2=304591&view=diff</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- libcxx/trunk/test/std/<wbr>experimental/language.support/<wbr>support.coroutines/end.to.end/<wbr>generator.pass.cpp (original)<br>
>> +++ libcxx/trunk/test/std/<wbr>experimental/language.support/<wbr>support.coroutines/end.to.end/<wbr>generator.pass.cpp Fri Jun  2 15:06:49 2017<br>
>> @@ -10,6 +10,9 @@<br>
>><br>
>> // UNSUPPORTED: c++98, c++03, c++11<br>
>><br>
>> +// See <a href="https://bugs.llvm.org/show_bug.cgi?id=33271" rel="noreferrer" target="_blank">https://bugs.llvm.org/show_<wbr>bug.cgi?id=33271</a><br>
>> +// UNSUPPORTED: ubsan<br>
>> +<br>
>> #include <experimental/coroutine><br>
>> #include <vector><br>
>> #include <cassert><br>
>><br>
>><br>
>> ______________________________<wbr>_________________<br>
>> cfe-commits mailing list<br>
>> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
><br>
> ______________________________<wbr>_________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
<br>
</div></div></blockquote></div><br></div>