<div dir="ltr">On some Windows bots, multiple back slashes are used as a single path separator so the path looks like:<div><br></div><div>build_dir\\\\bin\\\\clang</div><div><br></div><div>PREFIX_DIR would match "build_dir\\\\bin\\", the path separator matches "\", then the directory would match the empty string, and the final path separator would match the "\" before clang.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 29, 2017 at 11:18 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Why would matching on an empty string be bad in this case?</div><div class="m_1303128974297364333gmail-HOEnZb"><div class="m_1303128974297364333gmail-h5"><br><div class="gmail_quote"><div dir="ltr">On Thu, May 25, 2017 at 4:25 PM Richard Trieu via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: rtrieu<br>
Date: Thu May 25 18:25:36 2017<br>
New Revision: 303934<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=303934&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=303934&view=rev</a><br>
Log:<br>
"*" => "+" to avoid matching on empty string.<br>
<br>
Modified:<br>
    cfe/trunk/test/Driver/baremeta<wbr>l.cpp<br>
<br>
Modified: cfe/trunk/test/Driver/baremeta<wbr>l.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/baremetal.cpp?rev=303934&r1=303933&r2=303934&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/cfe/trunk/test/Driver/ba<wbr>remetal.cpp?rev=303934&r1=3039<wbr>33&r2=303934&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/test/Driver/baremeta<wbr>l.cpp (original)<br>
+++ cfe/trunk/test/Driver/baremeta<wbr>l.cpp Thu May 25 18:25:36 2017<br>
@@ -4,7 +4,7 @@<br>
 // RUN:     -L some/directory/user/asked/for \<br>
 // RUN:     --sysroot=%S/Inputs/baremetal<wbr>_arm \<br>
 // RUN:   | FileCheck --check-prefix=CHECK-V6M-C %s<br>
-// CHECK-V6M-C: "[[PREFIX_DIR:.*]]{{[/\\]+}}{{<wbr>[^/^\\]*}}{{[/\\]+}}clang{{.*}<wbr>}" "-cc1" "-triple" "thumbv6m-none--eabi"<br>
+// CHECK-V6M-C: "[[PREFIX_DIR:.*]]{{[/\\]+}}{{<wbr>[^/^\\]+}}{{[/\\]+}}clang{{.*}<wbr>}" "-cc1" "-triple" "thumbv6m-none--eabi"<br>
 // CHECK-V6M-C-SAME: "-resource-dir" "[[PREFIX_DIR]]{{[/\\]+}}lib{{<wbr>[/\\]+}}clang{{[/\\]+}}[[VERSI<wbr>ON:[^"]*]]"<br>
 // CHECK-V6M-C-SAME: "-isysroot" "[[SYSROOT:[^"]*]]"<br>
 // CHECK-V6M-C-SAME: "-internal-isystem" "[[SYSROOT]]{{[/\\]+}}include{<wbr>{[/\\]+}}c++{{[/\\]+}}v1"<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
</div></div></blockquote></div><br></div></div>