<div dir="ltr">Why would matching on an empty string be bad in this case?</div><br><div class="gmail_quote"><div dir="ltr">On Thu, May 25, 2017 at 4:25 PM Richard Trieu via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rtrieu<br>
Date: Thu May 25 18:25:36 2017<br>
New Revision: 303934<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=303934&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=303934&view=rev</a><br>
Log:<br>
"*" => "+" to avoid matching on empty string.<br>
<br>
Modified:<br>
    cfe/trunk/test/Driver/baremetal.cpp<br>
<br>
Modified: cfe/trunk/test/Driver/baremetal.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/baremetal.cpp?rev=303934&r1=303933&r2=303934&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/baremetal.cpp?rev=303934&r1=303933&r2=303934&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Driver/baremetal.cpp (original)<br>
+++ cfe/trunk/test/Driver/baremetal.cpp Thu May 25 18:25:36 2017<br>
@@ -4,7 +4,7 @@<br>
 // RUN:     -L some/directory/user/asked/for \<br>
 // RUN:     --sysroot=%S/Inputs/baremetal_arm \<br>
 // RUN:   | FileCheck --check-prefix=CHECK-V6M-C %s<br>
-// CHECK-V6M-C: "[[PREFIX_DIR:.*]]{{[/\\]+}}{{[^/^\\]*}}{{[/\\]+}}clang{{.*}}" "-cc1" "-triple" "thumbv6m-none--eabi"<br>
+// CHECK-V6M-C: "[[PREFIX_DIR:.*]]{{[/\\]+}}{{[^/^\\]+}}{{[/\\]+}}clang{{.*}}" "-cc1" "-triple" "thumbv6m-none--eabi"<br>
 // CHECK-V6M-C-SAME: "-resource-dir" "[[PREFIX_DIR]]{{[/\\]+}}lib{{[/\\]+}}clang{{[/\\]+}}[[VERSION:[^"]*]]"<br>
 // CHECK-V6M-C-SAME: "-isysroot" "[[SYSROOT:[^"]*]]"<br>
 // CHECK-V6M-C-SAME: "-internal-isystem" "[[SYSROOT]]{{[/\\]+}}include{{[/\\]+}}c++{{[/\\]+}}v1"<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>