<div dir="auto">Re add list</div><div class="gmail_extra"><br><div class="gmail_quote">On May 11, 2017 7:03 PM, "Reid Kleckner" <<a href="mailto:rnk@google.com">rnk@google.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto">The mailer divides patches by repo: llvm, cfe, compiler-rt, and this patch spanned clang and llvm. I'm living in the monorepo future. 😀</div><div class="gmail_extra"><br><div class="gmail_quote">On May 11, 2017 6:46 PM, "Nico Weber" <<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">The inline snippet doesn't show the actual code change, but <a href="http://llvm.org/viewvc/llvm-project?view=revision&revision=302835" target="_blank">http://llvm.org/viewvc/llv<wbr>m-project?view=revision&revisi<wbr>on=302835</a> does show it. Is the email sender broken?</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 11, 2017 at 6:43 PM, Reid Kleckner via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rnk<br>
Date: Thu May 11 17:43:02 2017<br>
New Revision: 302835<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=302835&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=302835&view=rev</a><br>
Log:<br>
Issue diagnostics when returning FP values on x86_64 without SSE1/2<br>
<br>
Avoid using report_fatal_error, because it will ask the user to file a<br>
bug. If the user attempts to disable SSE on x86_64 and them use floating<br>
point, that's a bug in their code, not a bug in the compiler.<br>
<br>
This is just a start. There are other ways to crash the backend in this<br>
configuration, but they should be updated to follow this pattern.<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D27522" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2752<wbr>2</a><br>
<br>
Added:<br>
    cfe/trunk/test/CodeGen/x86_64-<wbr>mno-sse.c<br>
<br>
Added: cfe/trunk/test/CodeGen/x86_64-<wbr>mno-sse.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/x86_64-mno-sse.c?rev=302835&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/cfe/trunk/test/CodeGen/x<wbr>86_64-mno-sse.c?rev=302835&vie<wbr>w=auto</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/test/CodeGen/x86_64-<wbr>mno-sse.c (added)<br>
+++ cfe/trunk/test/CodeGen/x86_64-<wbr>mno-sse.c Thu May 11 17:43:02 2017<br>
@@ -0,0 +1,15 @@<br>
+// RUN: %clang_cc1 -triple x86_64-linux -target-feature -sse -target-feature -sse2 -S -o /dev/null -verify %s<br>
+// REQUIRES: x86-registered-target<br>
+<br>
+double f1(void) { // expected-error {{SSE register return with SSE disabled}}<br>
+  return 1.4;<br>
+}<br>
+extern double g;<br>
+void f2(void) { // expected-error {{SSE register return with SSE disabled}}<br>
+  g = f1();<br>
+}<br>
+void take_double(double);<br>
+void pass_double(void) {<br>
+  // FIXME: Still asserts.<br>
+  //take_double(1.5);<br>
+}<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</blockquote></div></div>
</blockquote></div></div>