<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, May 5, 2017 at 1:21 PM, Aaron Ballman via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">On Fri, May 5, 2017 at 1:05 PM, Nico Weber via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
</span><div><div class="gmail-h5">> Author: nico<br>
> Date: Fri May 5 12:05:56 2017<br>
> New Revision: 302255<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=302255&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=302255&view=rev</a><br>
> Log:<br>
> Warn that the [] spelling of uuid(...) is deprecated.<br>
><br>
> <a href="https://reviews.llvm.org/D32879" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D32879</a><br>
><br>
> Modified:<br>
> cfe/trunk/include/clang/Basic/<wbr>DiagnosticSemaKinds.td<br>
> cfe/trunk/lib/Parse/<wbr>ParseDeclCXX.cpp<br>
> cfe/trunk/lib/Sema/<wbr>SemaDeclAttr.cpp<br>
> cfe/trunk/test/Parser/<wbr>MicrosoftExtensions.cpp<br>
> cfe/trunk/test/Parser/<a href="http://ms-square-bracket-attributes.mm" rel="noreferrer" target="_blank">ms-<wbr>square-bracket-attributes.mm</a><br>
> cfe/trunk/test/SemaCXX/ms-<wbr>uuid.cpp<br>
><br>
> Modified: cfe/trunk/include/clang/Basic/<wbr>DiagnosticSemaKinds.td<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=302255&r1=302254&r2=302255&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/include/<wbr>clang/Basic/<wbr>DiagnosticSemaKinds.td?rev=<wbr>302255&r1=302254&r2=302255&<wbr>view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- cfe/trunk/include/clang/Basic/<wbr>DiagnosticSemaKinds.td (original)<br>
> +++ cfe/trunk/include/clang/Basic/<wbr>DiagnosticSemaKinds.td Fri May 5 12:05:56 2017<br>
> @@ -730,6 +730,9 @@ def err_super_in_lambda_<wbr>unsupported : Er<br>
> def warn_pragma_unused_undeclared_<wbr>var : Warning<<br>
> "undeclared variable %0 used as an argument for '#pragma unused'">,<br>
> InGroup<IgnoredPragmas>;<br>
> +def warn_atl_uuid_deprecated : Warning<<br>
> + "specifying 'uuid' as an ATL attribute is deprecated; use __declspec instead">,<br>
> + InGroup<<wbr>DeprecatedDeclarations>;<br>
> def warn_pragma_unused_expected_<wbr>var_arg : Warning<<br>
> "only variables can be arguments to '#pragma unused'">,<br>
> InGroup<IgnoredPragmas>;<br>
><br>
> Modified: cfe/trunk/lib/Parse/<wbr>ParseDeclCXX.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/ParseDeclCXX.cpp?rev=302255&r1=302254&r2=302255&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/lib/Parse/<wbr>ParseDeclCXX.cpp?rev=302255&<wbr>r1=302254&r2=302255&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- cfe/trunk/lib/Parse/<wbr>ParseDeclCXX.cpp (original)<br>
> +++ cfe/trunk/lib/Parse/<wbr>ParseDeclCXX.cpp Fri May 5 12:05:56 2017<br>
> @@ -4151,8 +4151,6 @@ void Parser::<wbr>ParseMicrosoftUuidAttribute<br>
> }<br>
><br>
> if (!T.consumeClose()) {<br>
> - // FIXME: Warn that this syntax is deprecated, with a Fix-It suggesting<br>
> - // using __declspec(uuid()) instead.<br>
> Attrs.addNew(UuidIdent, SourceRange(UuidLoc, T.getCloseLocation()), nullptr,<br>
> SourceLocation(), ArgExprs.data(), ArgExprs.size(),<br>
> AttributeList::AS_Microsoft);<br>
><br>
> Modified: cfe/trunk/lib/Sema/<wbr>SemaDeclAttr.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclAttr.cpp?rev=302255&r1=302254&r2=302255&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/lib/Sema/<wbr>SemaDeclAttr.cpp?rev=302255&<wbr>r1=302254&r2=302255&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- cfe/trunk/lib/Sema/<wbr>SemaDeclAttr.cpp (original)<br>
> +++ cfe/trunk/lib/Sema/<wbr>SemaDeclAttr.cpp Fri May 5 12:05:56 2017<br>
> @@ -5079,6 +5079,15 @@ static void handleUuidAttr(Sema &S, Decl<br>
> }<br>
> }<br>
><br>
> + // FIXME: It'd be nice to also emit a fixit removing uuid(...) (and, if it's<br>
> + // the only thing in the [] list, the [] too), and add an insertion of<br>
> + // __declspec(uuid(...)). But sadly, neither the SourceLocs of the commas<br>
> + // separating attributes nor of the [ and the ] are in the AST.<br>
> + // Cf "SourceLocations of attribute list delimiters – [[ ... , ... ]] etc"<br>
<br>
</div></div>You introduced some non-ASCII characters in this comment. Can you fix that up?<br></blockquote><div><br></div><div>Sure, 302258. Thanks for catching. </div></div><br></div></div>