<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi,<div class=""><br class=""></div><div class="">I reverted in <span style="color: rgba(0, 0, 0, 0.85098); font-family: 'Helvetica Neue';" class="">r299656. MacOS bot is broken both on 64 and 32 bits:</span></div><div class=""><span style="color: rgba(0, 0, 0, 0.85098); font-family: 'Helvetica Neue';" class=""><br class=""></span></div><div class=""><font color="rgba(0, 0, 0, 0.85098)" face="Helvetica Neue" class=""><a href="http://green.lab.llvm.org/green/job/libcxx_master_cmake/83/" class="">http://green.lab.llvm.org/green/job/libcxx_master_cmake/83/</a></font></div><div class=""><font color="#000085" face="Helvetica Neue" class=""><a href="http://green.lab.llvm.org/green/job/libcxx_master_cmake_32/61/" class="">http://green.lab.llvm.org/green/job/libcxx_master_cmake_32/61/</a></font></div><div class=""><br class=""></div><div class="">It shouldn’t be too hard to fix though, it is full of the same error:</div><div class=""><br class=""></div><div class="">/Users/buildslave/jenkins/sharedspace/libcxx/libcxx.src/test/std/re/re.alg/re.alg.match/awk.pass.cpp:266:28: error: comparison of integers of different signs: 'difference_type' (aka 'long') and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare]</div><div class=""><br class="Apple-interchange-newline"><div class=""> assert(m.length(0) == std::char_traits<char>::length(s));</div><div class=""> ~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~</div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">— </div><div class="">Mehdi</div><div class=""><br class=""></div><div class=""><br class=""></div><br class="Apple-interchange-newline"><br class=""></div><div class=""><br class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Apr 6, 2017, at 7:32 AM, Marshall Clow via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Author: marshall<br class="">Date: Thu Apr 6 09:32:42 2017<br class="">New Revision: 299652<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=299652&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=299652&view=rev</a><br class="">Log:<br class="">Restore Missing awk regex tests. Thanks to dexonsmith for noticing, and proposing this as <a href="https://reviews.llvm.org/D16541" class="">https://reviews.llvm.org/D16541</a><br class=""><br class="">Modified:<br class=""> libcxx/trunk/test/std/re/re.alg/re.alg.match/awk.pass.cpp<br class=""><br class="">Modified: libcxx/trunk/test/std/re/re.alg/re.alg.match/awk.pass.cpp<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/re/re.alg/re.alg.match/awk.pass.cpp?rev=299652&r1=299651&r2=299652&view=diff" class="">http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/re/re.alg/re.alg.match/awk.pass.cpp?rev=299652&r1=299651&r2=299652&view=diff</a><br class="">==============================================================================<br class="">--- libcxx/trunk/test/std/re/re.alg/re.alg.match/awk.pass.cpp (original)<br class="">+++ libcxx/trunk/test/std/re/re.alg/re.alg.match/awk.pass.cpp Thu Apr 6 09:32:42 2017<br class="">@@ -26,7 +26,7 @@<br class=""><br class=""> int main()<br class=""> {<br class="">-/* {<br class="">+ {<br class=""> std::cmatch m;<br class=""> const char s[] = "a";<br class=""> assert(std::regex_match(s, m, std::regex("a", std::regex_constants::awk)));<br class="">@@ -616,13 +616,12 @@ int main()<br class=""> assert(m.size() == 0);<br class=""> }<br class=""> std::locale::global(std::locale(LOCALE_cs_CZ_ISO8859_2));<br class="">-*/ {<br class="">- /*<br class="">+ {<br class=""> std::cmatch m;<br class=""> const char s[] = "m";<br class="">- assert(std::regex_match(s, m, std::regex("[a[=M=]z]",<br class="">- std::regex_constants::awk);<br class="">- assert(m.size() == 1);<br class="">+ assert(std::regex_match(s, m, <br class="">+ std::regex("[a[=M=]z]", std::regex_constants::awk)));<br class="">+ assert(m.size() == 1);<br class=""> assert(!m.prefix().matched);<br class=""> assert(m.prefix().first == s);<br class=""> assert(m.prefix().second == m[0].first);<br class="">@@ -632,8 +631,8 @@ int main()<br class=""> assert(m.length(0) == std::char_traits<char>::length(s));<br class=""> assert(m.position(0) == 0);<br class=""> assert(m.str(0) == s);<br class="">-*/ }<br class="">-/* {<br class="">+ }<br class="">+ {<br class=""> std::cmatch m;<br class=""> const char s[] = "Ch";<br class=""> assert(std::regex_match(s, m, std::regex("[a[.ch.]z]",<br class="">@@ -1389,4 +1388,4 @@ int main()<br class=""> assert(m.position(0) == 0);<br class=""> assert(m.str(0) == s);<br class=""> }<br class="">-*/}<br class="">+}<br class=""><br class=""><br class="">_______________________________________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits<br class=""></div></div></blockquote></div><br class=""></div></body></html>