<div dir="ltr">This will be ABI breaking for Objective-C++ users. I'm not objecting to fixing the bogus configuration, but I just wanted to point it out.<div><br></div><div>/Eric</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 31, 2017 at 11:39 AM, Duncan P. N. Exon Smith via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dexonsmith<br>
Date: Fri Mar 31 12:39:56 2017<br>
New Revision: 299236<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=299236&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=299236&view=rev</a><br>
Log:<br>
Use strong enums independently of -fobjc-arc<br>
<br>
r145698 introduced _LIBCPP_HAS_NO_STRONG_ENUMS by copy-pasting the<br>
__has_feature check from objc_arc_weak/_LIBCPP_HAS_<wbr>OBJC_ARC_WEAK, and<br>
accidentally started defining _LIBCPP_HAS_NO_STRONG_ENUMS whenever<br>
__has_feature(objc_arc_weak).  This is totally bogus, and means that<br>
Libc++ thinks Objective-C++ compilations with -fobjc-arc don't have<br>
strong enums.<br>
<br>
Delete the accidental line.<br>
<br>
I thought about adding a test, but it would be entirely duplicative of<br>
the patch (if has-feature strong enums, check that has-no-strong-enums<br>
is not defined).<br>
<br>
Modified:<br>
    libcxx/trunk/include/__config<br>
<br>
Modified: libcxx/trunk/include/__config<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/__config?rev=299236&r1=299235&r2=299236&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/libcxx/trunk/include/_<wbr>_config?rev=299236&r1=299235&<wbr>r2=299236&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/include/__config (original)<br>
+++ libcxx/trunk/include/__config Fri Mar 31 12:39:56 2017<br>
@@ -348,7 +348,6 @@ typedef __char32_t char32_t;<br>
<br>
 #if __has_feature(objc_arc_weak)<br>
 #define _LIBCPP_HAS_OBJC_ARC_WEAK<br>
-#define _LIBCPP_HAS_NO_STRONG_ENUMS<br>
 #endif<br>
<br>
 #if !(__has_feature(cxx_constexpr)<wbr>)<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>