<div dir="rtl"><div dir="ltr">Thanks!</div><div dir="ltr">If you like, might make sense now to move all these addModuleFlag() into a new helper function, addModuleFlags().<br></div><div dir="ltr"><br></div></div><br><div class="gmail_quote"><div dir="rtl">‫בתאריך יום ה׳, 30 במרץ 2017 ב-16:54 מאת ‪Nirav Dave via cfe-commits‬‏ <‪<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>‬‏>:‬<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: niravd<br class="gmail_msg">
Date: Thu Mar 30 08:41:44 2017<br class="gmail_msg">
New Revision: 299079<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=299079&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=299079&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Move NumRegParameters Module Flag. NFCI.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    cfe/trunk/lib/CodeGen/CodeGenModule.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenModule.cpp?rev=299079&r1=299078&r2=299079&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenModule.cpp?rev=299079&r1=299078&r2=299079&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- cfe/trunk/lib/CodeGen/CodeGenModule.cpp (original)<br class="gmail_msg">
+++ cfe/trunk/lib/CodeGen/CodeGenModule.cpp Thu Mar 30 08:41:44 2017<br class="gmail_msg">
@@ -159,12 +159,6 @@ CodeGenModule::CodeGenModule(ASTContext<br class="gmail_msg">
   // CoverageMappingModuleGen object.<br class="gmail_msg">
   if (CodeGenOpts.CoverageMapping)<br class="gmail_msg">
     CoverageMapping.reset(new CoverageMappingModuleGen(*this, *CoverageInfo));<br class="gmail_msg">
-<br class="gmail_msg">
-  // Record mregparm value now so it is visible through rest of codegen.<br class="gmail_msg">
-  if (Context.getTargetInfo().getTriple().getArch() == llvm::Triple::x86)<br class="gmail_msg">
-    getModule().addModuleFlag(llvm::Module::Error, "NumRegisterParameters",<br class="gmail_msg">
-                              CodeGenOpts.NumRegisterParameters);<br class="gmail_msg">
-<br class="gmail_msg">
 }<br class="gmail_msg">
<br class="gmail_msg">
 CodeGenModule::~CodeGenModule() {}<br class="gmail_msg">
@@ -424,6 +418,11 @@ void CodeGenModule::Release() {<br class="gmail_msg">
     EmitModuleLinkOptions();<br class="gmail_msg">
   }<br class="gmail_msg">
<br class="gmail_msg">
+  // Record mregparm value now so it is visible through rest of codegen.<br class="gmail_msg">
+  if (Context.getTargetInfo().getTriple().getArch() == llvm::Triple::x86)<br class="gmail_msg">
+    getModule().addModuleFlag(llvm::Module::Error, "NumRegisterParameters",<br class="gmail_msg">
+                              CodeGenOpts.NumRegisterParameters);<br class="gmail_msg">
+<br class="gmail_msg">
   if (CodeGenOpts.DwarfVersion) {<br class="gmail_msg">
     // We actually want the latest version when there are conflicts.<br class="gmail_msg">
     // We can change from Warning to Latest if such mode is supported.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
cfe-commits mailing list<br class="gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="gmail_msg">
</blockquote></div>