<div dir="ltr">I don't know why this test failed only on Windows, but will revert my change soon.<div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 30, 2017 at 6:07 PM, Yung, Douglas <span dir="ltr"><<a href="mailto:douglas.yung@sony.com" target="_blank">douglas.yung@sony.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi, this change seems to be causing the test clang-tidy/llvm-include-order.<wbr>cpp to fail with a crash on the PS4 Windows bot:<br>
<br>
(From <a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/7487" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/llvm-clang-lld-x86_<wbr>64-scei-ps4-windows10pro-fast/<wbr>builds/7487</a>)<br>
<br>
******************** TEST 'Clang Tools :: clang-tidy/llvm-include-order.<wbr>cpp' FAILED ********************<br>
Script:<br>
--<br>
C:/Python27/python.exe C:/Buildbot/Slave/llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast/llvm.src/<wbr>tools/clang/tools/extra/test/.<wbr>./test\clang-tidy\check_clang_<wbr>tidy.py C:\Buildbot\Slave\llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast\llvm.src\<wbr>tools\clang\tools\extra\test\<wbr>clang-tidy\llvm-include-order.<wbr>cpp llvm-include-order C:\Buildbot\Slave\llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast\llvm.obj\<wbr>tools\clang\tools\extra\test\<wbr>clang-tidy\Output\llvm-<wbr>include-order.cpp.tmp -- -- -isystem C:\Buildbot\Slave\llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast\llvm.src\<wbr>tools\clang\tools\extra\test\<wbr>clang-tidy/Inputs/Headers<br>
--<br>
Exit Code: 1<br>
<br>
Command Output (stdout):<br>
--<br>
$ "C:/Python27/python.exe" "C:/Buildbot/Slave/llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast/llvm.src/<wbr>tools/clang/tools/extra/test/.<wbr>./test\clang-tidy\check_clang_<wbr>tidy.py" "C:\Buildbot\Slave\llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast\llvm.src\<wbr>tools\clang\tools\extra\test\<wbr>clang-tidy\llvm-include-order.<wbr>cpp" "llvm-include-order" "C:\Buildbot\Slave\llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast\llvm.obj\<wbr>tools\clang\tools\extra\test\<wbr>clang-tidy\Output\llvm-<wbr>include-order.cpp.tmp" "--" "--" "-isystem" "C:\Buildbot\Slave\llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast\llvm.src\<wbr>tools\clang\tools\extra\test\<wbr>clang-tidy/Inputs/Headers"<br>
# command output:<br>
Running ['clang-tidy', 'C:\\Buildbot\\Slave\\llvm-<wbr>clang-lld-x86_64-scei-ps4-<wbr>windows10pro-fast\\llvm.obj\\<wbr>tools\\clang\\tools\\extra\\<wbr>test\\clang-tidy\\Output\\<wbr>llvm-include-order.cpp.tmp.<wbr>cpp', '-fix', '--checks=-*,llvm-include-<wbr>order', '--', '-isystem', 'C:\\Buildbot\\Slave\\llvm-<wbr>clang-lld-x86_64-scei-ps4-<wbr>windows10pro-fast\\llvm.src\\<wbr>tools\\clang\\tools\\extra\\<wbr>test\\clang-tidy/Inputs/<wbr>Headers', '-nostdinc++']...<br>
clang-tidy failed:<br>
2 warnings generated.<br>
<br>
Assertion failed: EndColNo <= map.getSourceLine().size() && "Invalid range!", file C:\Buildbot\Slave\llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast\llvm.src\<wbr>tools\clang\lib\Frontend\<wbr>TextDiagnostic.cpp, line 999<br>
<br>
<br>
<br>
# command stderr:<br>
Traceback (most recent call last):<br>
<br>
  File "C:/Buildbot/Slave/llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast/llvm.src/<wbr>tools/clang/tools/extra/test/.<wbr>./test\clang-tidy\check_clang_<wbr>tidy.py", line 140, in <module><br>
<br>
    main()<br>
<br>
  File "C:/Buildbot/Slave/llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast/llvm.src/<wbr>tools/clang/tools/extra/test/.<wbr>./test\clang-tidy\check_clang_<wbr>tidy.py", line 96, in main<br>
<br>
    subprocess.check_output(args, stderr=subprocess.STDOUT).<wbr>decode()<br>
<br>
  File "C:\Python27\lib\subprocess.<wbr>py", line 573, in check_output<br>
<br>
    raise CalledProcessError(retcode, cmd, output=output)<br>
<br>
subprocess.CalledProcessError: Command '['clang-tidy', 'C:\\Buildbot\\Slave\\llvm-<wbr>clang-lld-x86_64-scei-ps4-<wbr>windows10pro-fast\\llvm.obj\\<wbr>tools\\clang\\tools\\extra\\<wbr>test\\clang-tidy\\Output\\<wbr>llvm-include-order.cpp.tmp.<wbr>cpp', '-fix', '--checks=-*,llvm-include-<wbr>order', '--', '-isystem', 'C:\\Buildbot\\Slave\\llvm-<wbr>clang-lld-x86_64-scei-ps4-<wbr>windows10pro-fast\\llvm.src\\<wbr>tools\\clang\\tools\\extra\\<wbr>test\\clang-tidy/Inputs/<wbr>Headers', '-nostdinc++']' returned non-zero exit status 255<br>
<br>
<br>
error: command failed with exit status: 1<br>
<br>
--<br>
<br>
********************<br>
<br>
Can you take a look?<br>
<br>
Douglas Yung<br>
<br>
> -----Original Message-----<br>
> From: cfe-commits [mailto:<a href="mailto:cfe-commits-bounces@lists.llvm.org">cfe-commits-bounces@<wbr>lists.llvm.org</a>] On Behalf Of<br>
> Chih-Hung Hsieh via cfe-commits<br>
> Sent: Thursday, March 30, 2017 15:09<br>
> To: <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> Subject: [clang-tools-extra] r299119 - [clang-tidy] Reuse FileID in<br>
> getLocation<br>
><br>
> Author: chh<br>
> Date: Thu Mar 30 17:09:17 2017<br>
> New Revision: 299119<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=299119&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=299119&view=rev</a><br>
> Log:<br>
> [clang-tidy] Reuse FileID in getLocation<br>
><br>
> One FileID per warning will increase and overflow NextLocalOffset when input<br>
> file is large with many warnings.<br>
> Reusing FileID avoids this problem.<br>
><br>
> Differential Revision: <a href="http://reviews.llvm.org/D31406" rel="noreferrer" target="_blank">http://reviews.llvm.org/D31406</a><br>
><br>
><br>
> Modified:<br>
>     clang-tools-extra/trunk/clang-<wbr>tidy/ClangTidy.cpp<br>
><br>
> Modified: clang-tools-extra/trunk/clang-<wbr>tidy/ClangTidy.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/clang-tools-extra/<wbr>trunk/clang-</a><br>
> tidy/ClangTidy.cpp?rev=299119&<wbr>r1=299118&r2=299119&view=diff<br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- clang-tools-extra/trunk/clang-<wbr>tidy/ClangTidy.cpp (original)<br>
> +++ clang-tools-extra/trunk/clang-<wbr>tidy/ClangTidy.cpp Thu Mar 30 17:09:17<br>
> +++ 2017<br>
> @@ -238,7 +238,7 @@ private:<br>
>        return SourceLocation();<br>
><br>
>      const FileEntry *File = SourceMgr.getFileManager().<wbr>getFile(FilePath);<br>
> -    FileID ID = SourceMgr.createFileID(File, SourceLocation(),<br>
> SrcMgr::C_User);<br>
> +    FileID ID = SourceMgr.getOrCreateFileID(<wbr>File, SrcMgr::C_User);<br>
>      return SourceMgr.<wbr>getLocForStartOfFile(ID).<wbr>getLocWithOffset(Offset);<br>
>    }<br>
><br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>