<div dir="ltr">Not sure, that's why I asked. Is it useful? Is it one of those things we want to remove since it'll be common among all of the TUs that want the text?</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Mar 24, 2017 at 3:43 PM Zhizhou Yang via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Sure I can add some more tests here.<div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">For -grecord-gcc-switches itself, I think maybe we could keep it in recording, since it is also one of the options from command line?</div></div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Fri, Mar 24, 2017 at 2:54 PM, Eric Christopher via Phabricator <span dir="ltr" class="gmail_msg"><<a href="mailto:reviews@reviews.llvm.org" class="gmail_msg" target="_blank">reviews@reviews.llvm.org</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">echristo added inline comments.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
================<br class="gmail_msg">
Comment at: test/Driver/debug-options.c:201-202<br class="gmail_msg">
<span class="gmail_msg"> //<br class="gmail_msg">
+// GRECORD: "-dwarf-debug-flags"<br class="gmail_msg">
+// GRECORD: -### -c -grecord-gcc-switches<br class="gmail_msg">
+//<br class="gmail_msg">
</span>----------------<br class="gmail_msg">
This seems a little light on the testing, would you mind adding some more interesting lines here? (Also, -grecord-gcc-switches seems like an option we might want to ignore for this?)<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D30760" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D30760</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div><br class="gmail_msg"></div>
_______________________________________________<br class="gmail_msg">
cfe-commits mailing list<br class="gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="gmail_msg">
</blockquote></div>