<div dir="ltr">Reading comprehension is hard. :)<div><br></div><div>Thanks for the catch.</div><div><br></div><div><div>echristo@athyra ~/s/l/t/clang> git svn dcommit</div><div>Committing to <a href="https://llvm.org/svn/llvm-project/cfe/trunk">https://llvm.org/svn/llvm-project/cfe/trunk</a> ...</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>M<span class="Apple-tab-span" style="white-space:pre"> </span>lib/Basic/Targets.cpp</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>M<span class="Apple-tab-span" style="white-space:pre"> </span>test/Preprocessor/init.c</div><div>Committed r298778</div></div><div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr">On Sat, Mar 25, 2017 at 12:44 AM David Majnemer <<a href="mailto:david.majnemer@gmail.com">david.majnemer@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Shouldn't this only be defined on 64-bit PPC platforms? I think that's what GCC does: <a href="https://github.com/gcc-mirror/gcc/blob/700a97608cadfe8adcd1a98e6388a5cbee9d76f6/gcc/config/rs6000/linux64.h#L372" class="gmail_msg" target="_blank">https://github.com/gcc-mirror/gcc/blob/700a97608cadfe8adcd1a98e6388a5cbee9d76f6/gcc/config/rs6000/linux64.h#L372</a></div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Fri, Mar 24, 2017 at 8:33 PM, Eric Christopher via cfe-commits <span dir="ltr" class="gmail_msg"><<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: echristo<br class="gmail_msg">
Date: Fri Mar 24 22:33:59 2017<br class="gmail_msg">
New Revision: 298765<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=298765&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=298765&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Add the _CALL_LINUX preprocessor define for ppc linux platforms.<br class="gmail_msg">
<br class="gmail_msg">
This typically is only for a new enough linker (bfd >= 2.16.2 or gold), but<br class="gmail_msg">
our ppc suppport post-dates this and it should work on all linux platforms. It<br class="gmail_msg">
is guaranteed to work on all elfv2 platforms.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
cfe/trunk/lib/Basic/Targets.cpp<br class="gmail_msg">
cfe/trunk/test/Preprocessor/init.c<br class="gmail_msg">
<br class="gmail_msg">
Modified: cfe/trunk/lib/Basic/Targets.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=298765&r1=298764&r2=298765&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=298765&r1=298764&r2=298765&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- cfe/trunk/lib/Basic/Targets.cpp (original)<br class="gmail_msg">
+++ cfe/trunk/lib/Basic/Targets.cpp Fri Mar 24 22:33:59 2017<br class="gmail_msg">
@@ -1237,6 +1237,12 @@ void PPCTargetInfo::getTargetDefines(con<br class="gmail_msg">
if (ABI == "elfv2")<br class="gmail_msg">
Builder.defineMacro("_CALL_ELF", "2");<br class="gmail_msg">
<br class="gmail_msg">
+ // This typically is only for a new enough linker (bfd >= 2.16.2 or gold), but<br class="gmail_msg">
+ // our suppport post-dates this and it should work on all linux platforms. It<br class="gmail_msg">
+ // is guaranteed to work on all elfv2 platforms.<br class="gmail_msg">
+ if (getTriple().getOS() == llvm::Triple::Linux)<br class="gmail_msg">
+ Builder.defineMacro("_CALL_LINUX", "1");<br class="gmail_msg">
+<br class="gmail_msg">
// Subtarget options.<br class="gmail_msg">
Builder.defineMacro("__NATURAL_ALIGNMENT__");<br class="gmail_msg">
Builder.defineMacro("__REGISTER_PREFIX__", "");<br class="gmail_msg">
<br class="gmail_msg">
Modified: cfe/trunk/test/Preprocessor/init.c<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Preprocessor/init.c?rev=298765&r1=298764&r2=298765&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Preprocessor/init.c?rev=298765&r1=298764&r2=298765&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- cfe/trunk/test/Preprocessor/init.c (original)<br class="gmail_msg">
+++ cfe/trunk/test/Preprocessor/init.c Fri Mar 24 22:33:59 2017<br class="gmail_msg">
@@ -6144,6 +6144,7 @@<br class="gmail_msg">
// PPC64-LINUX:#define _ARCH_PPC 1<br class="gmail_msg">
// PPC64-LINUX:#define _ARCH_PPC64 1<br class="gmail_msg">
// PPC64-LINUX:#define _BIG_ENDIAN 1<br class="gmail_msg">
+// PPC64-LINUX:#define _CALL_LINUX 1<br class="gmail_msg">
// PPC64-LINUX:#define _LP64 1<br class="gmail_msg">
// PPC64-LINUX:#define __BIGGEST_ALIGNMENT__ 16<br class="gmail_msg">
// PPC64-LINUX:#define __BIG_ENDIAN__ 1<br class="gmail_msg">
@@ -6346,6 +6347,11 @@<br class="gmail_msg">
// PPC64-ELFv1:#define _CALL_ELF 1<br class="gmail_msg">
// PPC64-ELFv2:#define _CALL_ELF 2<br class="gmail_msg">
//<br class="gmail_msg">
+// Most of this is encompassed in other places.<br class="gmail_msg">
+// RUN: %clang_cc1 -E -dM -ffreestanding -triple=powerpc64le-unknown-linux-gnu -target-abi elfv2 < /dev/null | FileCheck -match-full-lines -check-prefix PPC64LE-LINUX %s<br class="gmail_msg">
+//<br class="gmail_msg">
+// PPC64LE-LINUX:#define _CALL_LINUX 1<br class="gmail_msg">
+//<br class="gmail_msg">
// RUN: %clang_cc1 -E -dM -ffreestanding -triple=powerpc-none-none -fno-signed-char < /dev/null | FileCheck -match-full-lines -check-prefix PPC %s<br class="gmail_msg">
//<br class="gmail_msg">
// PPC:#define _ARCH_PPC 1<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
cfe-commits mailing list<br class="gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="gmail_msg">
</blockquote></div><br class="gmail_msg"></div>
</blockquote></div>