<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Thu, Mar 16, 2017 at 12:07 PM Reid Kleckner via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rnk<br class="gmail_msg">
Date: Thu Mar 16 13:55:46 2017<br class="gmail_msg">
New Revision: 297975<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=297975&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=297975&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Use arg_begin() instead of getArgumentList().begin(), the argument list is an implementation detail<br class="gmail_msg"></blockquote><div><br>Seems like a somewhat strange justification, given that getArgumentList looks like a public member and probably used pervasively before LLVM moved towards more iterator-centric interfaces, etc.<br><br>What do you mean by 'an implementation detail' in this context/what motivated this change? (curious what I'm missing)<br><br>- Dave<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp?rev=297975&r1=297974&r2=297975&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp?rev=297975&r1=297974&r2=297975&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp (original)<br class="gmail_msg">
+++ cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp Thu Mar 16 13:55:46 2017<br class="gmail_msg">
@@ -3780,9 +3780,7 @@ CGOpenMPRuntime::emitTaskInit(CodeGenFun<br class="gmail_msg">
   // Emit initial values for private copies (if any).<br class="gmail_msg">
   llvm::Value *TaskPrivatesMap = nullptr;<br class="gmail_msg">
   auto *TaskPrivatesMapTy =<br class="gmail_msg">
-      std::next(cast<llvm::Function>(TaskFunction)->getArgumentList().begin(),<br class="gmail_msg">
-                3)<br class="gmail_msg">
-          ->getType();<br class="gmail_msg">
+      std::next(cast<llvm::Function>(TaskFunction)->arg_begin(), 3)->getType();<br class="gmail_msg">
   if (!Privates.empty()) {<br class="gmail_msg">
     auto FI = std::next(KmpTaskTWithPrivatesQTyRD->field_begin());<br class="gmail_msg">
     TaskPrivatesMap = emitTaskPrivateMappingFunction(<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
cfe-commits mailing list<br class="gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="gmail_msg">
</blockquote></div></div>