<div dir="ltr">Great, thanks! Can you make this change instead Sean? :)<div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Mar 16, 2017 at 7:20 PM Hal Finkel <<a href="mailto:hfinkel@anl.gov">hfinkel@anl.gov</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000" class="gmail_msg">
    <p class="gmail_msg"><br class="gmail_msg">
    </p>
    <div class="m_2661277568490139120moz-cite-prefix gmail_msg">On 03/16/2017 08:11 PM, Eric
      Christopher wrote:<br class="gmail_msg">
    </div>
    <blockquote type="cite" class="gmail_msg">
      
      <div dir="ltr" class="gmail_msg"><br class="gmail_msg">
        <br class="gmail_msg">
        <div class="gmail_quote gmail_msg">
          <div dir="ltr" class="gmail_msg">On Thu, Mar 16, 2017 at 5:45 PM Hal Finkel <<a href="mailto:hfinkel@anl.gov" class="gmail_msg" target="_blank">hfinkel@anl.gov</a>>
            wrote:<br class="gmail_msg">
          </div>
          <blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div bgcolor="#FFFFFF" text="#000000" class="gmail_msg">
              <p class="gmail_msg"><br class="gmail_msg">
              </p>
              <div class="m_2661277568490139120m_-6314143797133193542moz-cite-prefix gmail_msg">On 03/16/2017 07:40 PM, Eric Christopher
                wrote:<br class="gmail_msg">
              </div>
              <blockquote type="cite" class="gmail_msg">
                <div dir="ltr" class="gmail_msg"><br class="gmail_msg">
                  <br class="gmail_msg">
                  <div class="gmail_quote gmail_msg">
                    <div dir="ltr" class="gmail_msg">On Thu, Mar 16,
                      2017 at 5:37 PM Hal Finkel via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="gmail_msg" target="_blank">reviews@reviews.llvm.org</a>>
                      wrote:<br class="gmail_msg">
                    </div>
                    <blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">hfinkel added a comment.<br class="gmail_msg">
                      <br class="gmail_msg">
                      In <a href="https://reviews.llvm.org/D30415#703398" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D30415#703398</a>,
                      @echristo wrote:<br class="gmail_msg">
                      <br class="gmail_msg">
                      > Different suggestion:<br class="gmail_msg">
                      ><br class="gmail_msg">
                      > Remove the faltivec option. Even gcc doesn't
                      support it anymore afaict.<br class="gmail_msg">
                      <br class="gmail_msg">
                      <br class="gmail_msg">
                      What are you suggesting? Always having the
                      language extensions on? Or explicitly tying the
                      language extensions to the underlying target
                      feature?<br class="gmail_msg">
                      <br class="gmail_msg">
                    </blockquote>
                    <div class="gmail_msg"><br class="gmail_msg">
                    </div>
                    <div class="gmail_msg">I was thinking the latter.</div>
                  </div>
                </div>
              </blockquote>
              <br class="gmail_msg">
            </div>
            <div bgcolor="#FFFFFF" text="#000000" class="gmail_msg"> Is
              that what GCC now does?<br class="gmail_msg">
              <br class="gmail_msg">
            </div>
          </blockquote>
          <div class="gmail_msg"><br class="gmail_msg">
          </div>
          <div class="gmail_msg">That would be my guess given the option isn't listed
            anymore, but what it does is this:</div>
          <div class="gmail_msg"><br class="gmail_msg">
          </div>
          <div class="gmail_msg">
            <div class="gmail_msg">echristo@dzur ~/s/gcc-git> grep -r faltivec *</div>
            <div class="gmail_msg">gcc/testsuite/gcc.target/powerpc/stabs-attrib-vect-darwin.c:/*
              { dg-options "-gstabs+ -fno-eliminate-unused-debug-types
              -faltivec" } */</div>
            <div class="gmail_msg">gcc/testsuite/ChangeLog-1993-2007:<span class="m_2661277568490139120Apple-tab-span gmail_msg" style="white-space:pre-wrap">        </span>*
              g++.dg/ext/altivec-8.C: Use '-maltivec' instead of
              '-faltivec';</div>
            <div class="gmail_msg">gcc/config/rs6000/darwin.h:   the kernel or some such. 
              The "-faltivec" option should have been</div>
            <div class="gmail_msg">gcc/config/rs6000/darwin.h:  %{faltivec:-maltivec
              -include altivec.h} %{fno-altivec:-mno-altivec} \</div>
            <div class="gmail_msg">gcc/config/rs6000/darwin.h:  %<faltivec
              %<fno-altivec " \</div>
            <div class="gmail_msg">gcc/config/rs6000/darwin.opt:faltivec</div>
            <div class="gmail_msg">gcc/ChangeLog-2003:<span class="m_2661277568490139120Apple-tab-span gmail_msg" style="white-space:pre-wrap">       </span>-maltivec
              is specified, not the non-existent -faltivec.</div>
            <div class="gmail_msg">gcc/ChangeLog-2010:<span class="m_2661277568490139120Apple-tab-span gmail_msg" style="white-space:pre-wrap">       </span>*
              config/rs6000/darwin.h (CC1_SPEC): Handle -faltivec and
              -fno-altivec.</div>
            <div class="gmail_msg">gcc/ChangeLog-2010:<span class="m_2661277568490139120Apple-tab-span gmail_msg" style="white-space:pre-wrap">       </span>*
              config/rs6000/darwin.opt (Waltivec-long-deprecated,
              faltivec,</div>
            <div class="gmail_msg"><br class="gmail_msg">
            </div>
            <div class="gmail_msg">and only on darwin. I don't see anything that treats
              the faltivec alias as anything language specific anywhere.
              It basically just says "pass the include and turn on
              maltivec".<br class="gmail_msg">
            </div>
          </div>
          <div class="gmail_msg"><br class="gmail_msg">
          </div>
          <div class="gmail_msg">At this point I'm pretty sure that -faltivec can just be
            ignored.</div>
        </div>
      </div>
    </blockquote>
    <br class="gmail_msg"></div><div bgcolor="#FFFFFF" text="#000000" class="gmail_msg">
    It is certainly fair to say that having the ability to use
    -fno-altivec was much more important when -faltivec included
    altivec.h (which injected names like vec_add into the global
    namespace). I'm fine with enabling the vector syntax extensions when
    targeting altivec is enabled (they're extensions to extensions
    anyway).</div><div bgcolor="#FFFFFF" text="#000000" class="gmail_msg"><br class="gmail_msg">
    <br class="gmail_msg">
     -Hal</div><div bgcolor="#FFFFFF" text="#000000" class="gmail_msg"><br class="gmail_msg">
    <br class="gmail_msg">
    <blockquote type="cite" class="gmail_msg">
      <div dir="ltr" class="gmail_msg">
        <div class="gmail_quote gmail_msg">
          <div class="gmail_msg"><br class="gmail_msg">
          </div>
          <div class="gmail_msg">-eric</div>
          <div class="gmail_msg"><br class="gmail_msg">
          </div>
          <div class="gmail_msg"> </div>
          <blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div bgcolor="#FFFFFF" text="#000000" class="gmail_msg">
               -Hal</div>
            <div bgcolor="#FFFFFF" text="#000000" class="gmail_msg"><br class="gmail_msg">
              <br class="gmail_msg">
              <blockquote type="cite" class="gmail_msg">
                <div dir="ltr" class="gmail_msg">
                  <div class="gmail_quote gmail_msg">
                    <div class="gmail_msg"><br class="gmail_msg">
                    </div>
                    <div class="gmail_msg">-eric</div>
                    <div class="gmail_msg"> </div>
                    <blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> > (Go ahead and commit
                      the zvector part if you'd like).<br class="gmail_msg">
                      ><br class="gmail_msg">
                      > -eric<br class="gmail_msg">
                      <br class="gmail_msg">
                      <br class="gmail_msg">
                      <br class="gmail_msg">
                      <br class="gmail_msg">
                      <a href="https://reviews.llvm.org/D30415" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D30415</a><br class="gmail_msg">
                      <br class="gmail_msg">
                      <br class="gmail_msg">
                      <br class="gmail_msg">
                    </blockquote>
                  </div>
                </div>
              </blockquote>
              <br class="gmail_msg">
            </div>
            <div bgcolor="#FFFFFF" text="#000000" class="gmail_msg">
              <pre class="m_2661277568490139120m_-6314143797133193542moz-signature gmail_msg" cols="72">-- 
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory</pre>
            </div>
          </blockquote>
        </div>
      </div>
    </blockquote>
    <br class="gmail_msg">
    <pre class="m_2661277568490139120moz-signature gmail_msg" cols="72">-- 
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory</pre>
  </div></blockquote></div>