<div dir="ltr">;)</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Mar 16, 2017 at 7:13 PM Argyrios Kyrtzidis <<a href="mailto:akyrtzi@gmail.com">akyrtzi@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg">*boooo* at the gcc bots, those are the worst… :-P</div></div><div style="word-wrap:break-word" class="gmail_msg"><br class="gmail_msg"><div class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg">On Mar 16, 2017, at 6:39 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" class="gmail_msg" target="_blank">echristo@gmail.com</a>> wrote:</div><br class="m_3960637069190457272Apple-interchange-newline gmail_msg"><div class="gmail_msg"><div dir="ltr" class="gmail_msg">Also gcc bots fwiw :)<div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">-eric</div></div><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Thu, Mar 16, 2017 at 6:01 PM Argyrios Kyrtzidis via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: akirtzidis<br class="gmail_msg">
Date: Thu Mar 16 19:49:42 2017<br class="gmail_msg">
New Revision: 298027<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=298027&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=298027&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
[Serialization] Follow-up to r297972, deserialize name/loc in separate statements to make sure they deserialize in defined order.<br class="gmail_msg">
<br class="gmail_msg">
This should fix the windows bots.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    cfe/trunk/lib/Serialization/ASTReaderDecl.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: cfe/trunk/lib/Serialization/ASTReaderDecl.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTReaderDecl.cpp?rev=298027&r1=298026&r2=298027&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTReaderDecl.cpp?rev=298027&r1=298026&r2=298027&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- cfe/trunk/lib/Serialization/ASTReaderDecl.cpp (original)<br class="gmail_msg">
+++ cfe/trunk/lib/Serialization/ASTReaderDecl.cpp Thu Mar 16 19:49:42 2017<br class="gmail_msg">
@@ -1124,10 +1124,12 @@ void ASTDeclReader::VisitObjCPropertyDec<br class="gmail_msg">
       (ObjCPropertyDecl::PropertyAttributeKind)Record.readInt());<br class="gmail_msg">
   D->setPropertyImplementation(<br class="gmail_msg">
       (ObjCPropertyDecl::PropertyControl)Record.readInt());<br class="gmail_msg">
-  D->setGetterName(Record.readDeclarationName().getObjCSelector(),<br class="gmail_msg">
-                   ReadSourceLocation());<br class="gmail_msg">
-  D->setSetterName(Record.readDeclarationName().getObjCSelector(),<br class="gmail_msg">
-                   ReadSourceLocation());<br class="gmail_msg">
+  DeclarationName GetterName = Record.readDeclarationName();<br class="gmail_msg">
+  SourceLocation GetterLoc = ReadSourceLocation();<br class="gmail_msg">
+  D->setGetterName(GetterName.getObjCSelector(), GetterLoc);<br class="gmail_msg">
+  DeclarationName SetterName = Record.readDeclarationName();<br class="gmail_msg">
+  SourceLocation SetterLoc = ReadSourceLocation();<br class="gmail_msg">
+  D->setSetterName(SetterName.getObjCSelector(), SetterLoc);<br class="gmail_msg">
   D->setGetterMethodDecl(ReadDeclAs<ObjCMethodDecl>());<br class="gmail_msg">
   D->setSetterMethodDecl(ReadDeclAs<ObjCMethodDecl>());<br class="gmail_msg">
   D->setPropertyIvarDecl(ReadDeclAs<ObjCIvarDecl>());<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
cfe-commits mailing list<br class="gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="gmail_msg">
</blockquote></div>
</div></blockquote></div><br class="gmail_msg"></div></blockquote></div>